Close documentation update payment-channel

[arturoBeccar]

No description provided.

[github-actions]

Scout Report - 2024-05-28 20:34:12

Summary

• Assert Violation (3 results) (Medium)
• Zero Address (4 results) (Minor)
• Check Soroban version (1 results) (Enhancement)

Panic

Assert Violation

Impact: Medium

Description: Assert causes panic. Instead, return a proper error.

More about: here

ID	Detection	Status
0	src/lib.rs:117:9 - 117:52	False Positive Acknowledged Resolved
1	src/lib.rs:159:17 - 159:43	False Positive Acknowledged Resolved
2	src/lib.rs:179:9 - 179:46	False Positive Acknowledged Resolved

Validations and error handling

Zero Address

Impact: Minor

Description: Not checking for a zero-address could lead to an insecure contract

More about: here

Unrestricted Transfer From

Impact: Critical

Description: This argument comes from a user-supplied argument

More about: here

ID	Detection	Status
4	src/lib.rs:73:14 - 73:20	False Positive Acknowledged Resolved
5	src/lib.rs:44:9 - 44:24	False Positive Acknowledged Resolved
6	src/lib.rs:45:9 - 45:27	False Positive Acknowledged Resolved
7	src/lib.rs:46:9 - 46:23	False Positive Acknowledged Resolved

Best practices

Check Soroban version

Impact: Enhancement

Description: Use the latest version of Soroban

More about: here

ID	Detection	Status
3	src/lib.rs:1:1 - 1:1	False Positive Acknowledged Resolved