Skip to content

Conversation

@fingolfin
Copy link

@fingolfin fingolfin commented Oct 21, 2025

There are still a bunch of references to https://github.com/tlienart2/tlienart2.github.io and https://github.com/tlienart2/myWebsite where I am not sure what to do with them.

Also, one link to http://github.com/tlienart/FranklinUtils.jl (note the http ;-) )

@tlienart
Copy link
Collaborator

Nice thanks a bunch; I think the failing tests in sitemap.jl should be a simple fix

<loc>https://tlienart.github.io/FranklinTemplates.jl/$pgg</loc>""", fc)
end
end
@testset "Robots.txt gen" begin
f = joinpath(p, "basic", "__site", "robots.txt")
@test isfile(f)
fc = prod(readlines(f, keep=true))
@test occursin(raw"""
Sitemap: https://tlienart.github.io/FranklinTemplates.jl/sitemap.xml""", fc)

@fingolfin
Copy link
Author

I think the failing tests in sitemap.jl should be a simple fix

OK, I am not sure what that's saying, though: that you see a fix and will apply it (great!). Or that you see a fix and I should apply it? Less great, because to me the errors is inscrutable: it looks as if something somewhere is still producing URLs containing https://tlienart.github.io/FranklinTemplates.jl/ -- but where is that coming from?!?

@fingolfin
Copy link
Author

Maybe the failure is caused by the repository https://github.com/JuliaDocs/FranklinTemplates.jl having https://tlienart.github.io/FranklinTemplates.jl/ as its homepage in the GitHub metadata. That should be changed to https://juliadocs.org/FranklinTemplates.jl/ as well. And then see also JuliaDocs/FranklinTemplates.jl#183

@fingolfin fingolfin closed this Oct 22, 2025
@fingolfin fingolfin reopened this Oct 22, 2025
@fingolfin fingolfin closed this Oct 23, 2025
@tlienart tlienart reopened this Oct 24, 2025
@fingolfin
Copy link
Author

I think CI fails because the bad URL is pulled from FranklinTemplates.jl -- while my fix for the URL was merged, it is not yet in a release of that package, and thus CI does not pick it up.

@ViralBShah
Copy link
Contributor

Should we release a new version to be able to merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants