Skip to content

[wip] tests #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
itrush wants to merge 12 commits into
base: player-model-main
Choose a base branch
from
Draft

[wip] tests #1413

itrush wants to merge 12 commits into from

Conversation

@itrush
Copy link
Contributor

@itrush itrush commented Dec 3, 2025 •
edited by niels-s
Loading

Description

1 Line Summary

Details

Systems Affected

  • WebSDK
  • Backend
  • Dashboard

Validation

Tests

Info

Checklist

  • All the automated tests pass or I explained why that is not possible
  • I have personally tested this on my machine or explained why that is not possible
  • I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

  • Don't use default export
  • New interfaces are in model files

Functions:

  • Don't use default export
  • All function signatures have return types
  • Helpers should not access any data but rather be given the data to operate on.

Typescript:

  • No Typescript warnings
  • Avoid silencing null/undefined warnings with the exclamation point

Other:

  • Iteration: refrain from using elem of array syntax. Prefer forEach or use map
  • Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

Checklist

  • I have included screenshots/recordings of the intended results or explained why they are not needed

Related Tickets

This change is Reviewable

itrush added 12 commits August 7, 2025 12:55
@itrush
Update things to be able to build web sdk locally
b8d0d84
@itrush
Loosen the type definiion on Database.setAppState
71d5b29 
Code already handles each property separately so there's no reason to
force passing the whole object.
@itrush
Add an api call for web config if no default url
976d696 
There was an issue with legacy HTTP integrations where the
defaultNotificationUrl was never saved in the DB. To account for this,
we try to get the default URL from the app config on notification click
and save it to the DB for the future use.

Choosing between notification received and clicked to add this logic,
decided on notification clicked to avoid doing extra api call when the
user may never click the notification.
@itrush
Update type for worker message events
baee99a
@itrush
Bump up version
94caa07
@itrush
Update ubuntu image for ci
26a367b
@itrush
Minimal ts changes to let the test run
6ee87e4
@itrush
fixup! Add an api call for web config if no default url
2c741e2
@itrush
Test for config call
e91fb42
@itrush
Add await to database save call
6571574
@itrush
use undici instead of nock
fb49478
@itrush
fix other tests
0fb49b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@itrush