-
Notifications
You must be signed in to change notification settings - Fork 187
refactor(step-generation, shared-data): use set_stored_labware_items and fill_items #20293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: edge
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## edge #20293 +/- ##
==========================================
- Coverage 25.78% 25.78% -0.01%
==========================================
Files 3623 3624 +1
Lines 301816 301881 +65
Branches 42342 42350 +8
==========================================
- Hits 77827 77826 -1
- Misses 223960 224026 +66
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| export interface FlexStackerSetStoredLabwareItemsRunTimeCommand | ||
| extends FlexStackerSetStoredLabwareItemsCreateCommand, | ||
| CommonCommandRunTimeInfo { | ||
| result?: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we move this to its own type?
| robotStateAndWarnings: RobotStateAndWarnings | ||
| ): void => { | ||
| // TODO: we need to update both the labwareInHopper key and all the robotState.labware entities currently in the hopper | ||
| // const { robotState } = robotStateAndWarnings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this commented out on purpose?
TamarZanzouri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! had a few questions but this is good to merge once we get those questions answered :-)
closes EXEC-2102
Overview
Emit
fill_items()andset_stored_labware_items()instead offill()andset_stored_labware(). you can't smoke test this yet thoughAlso i reverted
retrieve()back to before lol.This change came from the meeting today:
Example code we should get from this:
Test Plan and Hands on Testing
review the code. i didn't wire up
fill_items()state update because idk the whole shape of moduleState yet???Changelog
add the missing types
refactor fill and set stored labware utils
add test cases
Risk assessment
low