Skip to content

Conversation

@jerader
Copy link
Collaborator

@jerader jerader commented Dec 4, 2025

closes EXEC-2102

Overview

Emit fill_items() and set_stored_labware_items() instead of fill() and set_stored_labware(). you can't smoke test this yet though

Also i reverted retrieve() back to before lol.

This change came from the meeting today:

Example code we should get from this:

plate_1 = load_labware(location: offDeck)
plate_2 = load_labware(location: offDeck)
stacker_1 = load_module()
stacker_1.set_stored_labware_items([plate_1])
stacker_1.retrieve() // retrieve plate_1
stacker_1.fill_items([plate_2])
stacker_1.retrieve() // retrieve plate_2

Test Plan and Hands on Testing

review the code. i didn't wire up fill_items() state update because idk the whole shape of moduleState yet???

Changelog

add the missing types
refactor fill and set stored labware utils
add test cases

Risk assessment

low

@jerader jerader requested a review from a team as a code owner December 4, 2025 20:53
@jerader jerader requested review from TamarZanzouri, ddcc4 and ncdiehl11 and removed request for a team and ncdiehl11 December 4, 2025 20:53
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 82.85714% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.78%. Comparing base (118329d) to head (dcf39d3).
⚠️ Report is 3 commits behind head on edge.

Files with missing lines Patch % Lines
...neration/src/getNextRobotStateAndWarnings/index.ts 25.00% 6 Missing ⚠️
...src/getNextRobotStateAndWarnings/stackerUpdates.ts 16.66% 5 Missing ⚠️
step-generation/src/utils/pythonFileUtils.ts 94.44% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #20293      +/-   ##
==========================================
- Coverage   25.78%   25.78%   -0.01%     
==========================================
  Files        3623     3624       +1     
  Lines      301816   301881      +65     
  Branches    42342    42350       +8     
==========================================
- Hits        77827    77826       -1     
- Misses     223960   224026      +66     
  Partials       29       29              
Flag Coverage Δ
protocol-designer 19.29% <4.28%> (-0.01%) ⬇️
step-generation 5.59% <82.85%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...src/commandCreators/atomic/flexStackerFillItems.ts 100.00% <100.00%> (ø)
.../src/commandCreators/atomic/flexStackerRetrieve.ts 100.00% <100.00%> (ø)
step-generation/src/utils/pythonFileUtils.ts 87.85% <94.44%> (-0.15%) ⬇️
...src/getNextRobotStateAndWarnings/stackerUpdates.ts 87.70% <16.66%> (-2.47%) ⬇️
...neration/src/getNextRobotStateAndWarnings/index.ts 69.33% <25.00%> (-0.97%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

export interface FlexStackerSetStoredLabwareItemsRunTimeCommand
extends FlexStackerSetStoredLabwareItemsCreateCommand,
CommonCommandRunTimeInfo {
result?: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we move this to its own type?

robotStateAndWarnings: RobotStateAndWarnings
): void => {
// TODO: we need to update both the labwareInHopper key and all the robotState.labware entities currently in the hopper
// const { robotState } = robotStateAndWarnings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this commented out on purpose?

Copy link
Contributor

@TamarZanzouri TamarZanzouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! had a few questions but this is good to merge once we get those questions answered :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants