Skip to content

Commit 2a4fe60

Browse files
committed
speed up Ruby test element_spec.rb
instead of sleeping for 0.5s, just wait for the needed title.
1 parent 48a1cdb commit 2a4fe60

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

rb/spec/integration/selenium/webdriver/element_spec.rb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -59,39 +59,39 @@ module WebDriver
5959
driver.navigate.to url_for('formPage.html')
6060
wait_for_element(id: 'submitButton').submit
6161

62-
sleep 0.5
62+
wait_for_new_url('formPage.html')
6363
expect(driver.title).to eq('We Arrive Here')
6464
end
6565

6666
it 'any input element in form' do
6767
driver.navigate.to url_for('formPage.html')
6868
wait_for_element(id: 'checky').submit
6969

70-
sleep 0.5
70+
wait_for_new_url('formPage.html')
7171
expect(driver.title).to eq('We Arrive Here')
7272
end
7373

7474
it 'any element in form' do
7575
driver.navigate.to url_for('formPage.html')
7676
wait_for_element(css: 'form > p').submit
7777

78-
sleep 0.5
78+
wait_for_new_url('formPage.html')
7979
expect(driver.title).to eq('We Arrive Here')
8080
end
8181

8282
it 'button with id submit' do
8383
driver.navigate.to url_for('formPage.html')
8484
wait_for_element(id: 'submit').submit
8585

86-
sleep 0.5
86+
wait_for_new_url('formPage.html')
8787
expect(driver.title).to eq('We Arrive Here')
8888
end
8989

9090
it 'button with name submit' do
9191
driver.navigate.to url_for('formPage.html')
9292
wait_for_element(name: 'submit').submit
9393

94-
sleep 0.5
94+
wait_for_new_url('formPage.html')
9595
expect(driver.title).to eq('We Arrive Here')
9696
end
9797

rb/spec/integration/selenium/webdriver/spec_support/helpers.rb

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,11 @@ def wait_for_devtools_target(target_type:)
102102
wait.until { driver.devtools(target_type: target_type).target }
103103
end
104104

105+
def wait_for_title(title:)
106+
wait = Wait.new(timeout: 5)
107+
wait.until { driver.title == title }
108+
end
109+
105110
def wait(timeout = 10)
106111
Wait.new(timeout: timeout)
107112
end

0 commit comments

Comments
 (0)