Transformers.js line items shouldn't load resources in the benchmark #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now some of the resources are loaded via relative paths in the benchmark. Instead of trying to patch the benchmark to use the blob, this patch makes it easier to redirect `fetch` so that it can find the already loaded data. I did this by adding a `JetStream.resources` object that maps from the original relative path resource to the blobURLOrPath vended by the preloader.
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
This addresses #183 |
Constellation
approved these changes
Nov 13, 2025
Contributor
Author
|
I'm just gonna merge this since it's (hopefully) non-controversial. Happy to address any feedback in a followup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now some of the resources are loaded via relative paths in the benchmark. Instead of trying to patch the benchmark to use the blob, this patch makes it easier to redirect
fetchso that it can find the already loaded data.I did this by adding a
JetStream.resourcesobject that maps from the original relative path resource to the blobURLOrPath vended by the preloader.