Skip to content

fix(cdk/scrolling): handle null document.body in ViewportRuler #32477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arturovt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(cdk/scrolling): handle null document.body in ViewportRuler #32477

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/cdk/scrolling/viewport-ruler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,14 +125,17 @@ export class ViewportRuler implements OnDestroy {

const top =
-documentRect.top ||
document.body.scrollTop ||
// `document.body` can be `null` per WHATWG spec when document element is not `<html>`
// or has no body/frameset child: https://html.spec.whatwg.org/multipage/dom.html#dom-document-body
// Note: TypeScript incorrectly types this as non-nullable, but it can be `null` in practice.
document.body?.scrollTop ||
window.scrollY ||
documentElement.scrollTop ||
0;

const left =
-documentRect.left ||
document.body.scrollLeft ||
document.body?.scrollLeft ||
window.scrollX ||
documentElement.scrollLeft ||
0;
Expand Down
Loading