Skip to content

fix(cdk/overlay): error when attempting to attach disposed overlay #32489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
crisbeto merged 1 commit into from
Dec 5, 2025
Merged

fix(cdk/overlay): error when attempting to attach disposed overlay #32489

crisbeto merged 1 commit into from
Dec 5, 2025
+17 −0

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 5, 2025

Fixes an error that was being thrown when calling attach on an overlay that was disposed already.

@crisbeto
fix(cdk/overlay): error when attempting to attach disposed overlay
8f368e6 
Fixes an error that was being thrown when calling `attach` on an overlay that was disposed already.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Dec 5, 2025
@pullapprove pullapprove bot requested review from tjshiu and wagnermaciel December 5, 2025 13:10
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Dec 5, 2025
@crisbeto crisbeto removed the request for review from tjshiu December 5, 2025 19:34
@crisbeto crisbeto merged commit 52720a3 into angular:main Dec 5, 2025
26 of 30 checks passed
@crisbeto
Copy link
Member Author

crisbeto commented Dec 5, 2025

This PR was merged into the repository. The changes were merged into the following branches:

crisbeto added a commit that referenced this pull request Dec 5, 2025
@crisbeto
fix(cdk/overlay): error when attempting to attach disposed overlay (#…
09ec449 
…32489)

Fixes an error that was being thrown when calling `attach` on an overlay that was disposed already.

(cherry picked from commit 52720a3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wagnermaciel wagnermaciel wagnermaciel approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: cdk/overlay target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@crisbeto @wagnermaciel