Feature/iotconsensus snap multi dir #16811
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jt2594838
reviewed
Dec 2, 2025
Comment on lines
344
to
345
| // debug print the path of consensus dir | ||
| System.out.println(file.getAbsolutePath()); |
Comment on lines
543
to
481
| @Override | ||
| public String getRegionDirFromConsensusGroupId(ConsensusGroupId groupId) { | ||
| return buildPeerDir(storageDir, groupId); | ||
| return null; | ||
| } |
Comment on lines
116
to
137
| public String getFolderByHashId(int hashId) throws DiskSpaceInsufficientException { | ||
| if (folders.isEmpty()) { | ||
| throw new DiskSpaceInsufficientException(folders); | ||
| } | ||
|
|
||
| List<String> healthyFolders = | ||
| folders.stream() | ||
| .filter( | ||
| folder -> | ||
| foldersStates.getOrDefault(folder, FolderState.ABNORMAL) == FolderState.HEALTHY) | ||
| .collect(Collectors.toList()); | ||
|
|
||
| if (healthyFolders.isEmpty()) { | ||
| logger.error("No healthy folders available, change system mode to read-only."); | ||
| CommonDescriptor.getInstance().getConfig().setNodeStatus(NodeStatus.ReadOnly); | ||
| CommonDescriptor.getInstance().getConfig().setStatusReason(NodeStatus.DISK_FULL); | ||
| throw new DiskSpaceInsufficientException(folders); | ||
| } | ||
|
|
||
| int index = Math.abs(hashId) % healthyFolders.size(); | ||
| return healthyFolders.get(index); | ||
| } |
Contributor
There was a problem hiding this comment.
If the healthy status of the folders changes, then the same region will be distributed to different folders, and the judgement below will also be invalid?
Contributor
|
Should include some compatibility design, like adding storageDir to storageDirs. |
This reverts commit 1fef8e4.
# Conflicts: # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/receiver/protocol/thrift/IoTDBDataNodeReceiver.java # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/util/LoadUtil.java
hongzhi-gao
force-pushed
the
feature/iotconsensus-snap-multi-dir
branch
from
85037c6 to
7f86ba6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR