Skip to content

Cannot use Rovo Dev with a *.jira.com site because it is not saved as a cloud site #1369

@jkmatila

Description

@jkmatila

Describe the bug
When adding an API Token for a *.jira.com site, the extension saves the site with "isCloud":false. Rovo Dev cannot use it, because ClientManager.getCloudPrimarySite() only considers sites where isCloud === true, so it never returns it as a primary site. As a result, Rovo Dev in VS Code always reports:

RovoDevEntitlementError: No valid Rovo Dev credentials found

To Reproduce
Steps to reproduce the behavior:

  1. From the VS Code activity bar, select Rovo Dev.
  2. Click "Add API Token".
  3. Enter a *.jira.com site as the Base URL.
  4. Enter your email.
  5. Enter an API token.
  6. Click "Save Site".

Expected behavior
Rovo Dev view should show "Welcome to Rovo Dev Beta"

Observed behavior

  • Rovo Dev view keeps showing the "Add API Token" button.
  • Output log contains "Unable to check Rovo Dev entitlement RovoDevEntitlementError: No valid Rovo Dev credentials found"
  • globalStorage shows the site saved with "isCloud":false

Environment and Version:

  • Atlassian Plugin Version 4.1.62 and 4.0.11
  • Visual Studio Code Version 1.106.3
  • OS: Windows, Linux (WSL2)

Additional context
There seem to be places in the code where only URLs ending in '.atlassian.net' are considered to be cloud URLs, and '.jira.com' URLs are not considered. For example here:

const CLOUD_TLD = '.atlassian.net';

Metadata

Metadata

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions