-
Notifications
You must be signed in to change notification settings - Fork 55
Description
Describe the bug
When adding an API Token for a *.jira.com site, the extension saves the site with "isCloud":false. Rovo Dev cannot use it, because ClientManager.getCloudPrimarySite() only considers sites where isCloud === true, so it never returns it as a primary site. As a result, Rovo Dev in VS Code always reports:
RovoDevEntitlementError: No valid Rovo Dev credentials found
To Reproduce
Steps to reproduce the behavior:
- From the VS Code activity bar, select Rovo Dev.
- Click "Add API Token".
- Enter a *.jira.com site as the Base URL.
- Enter your email.
- Enter an API token.
- Click "Save Site".
Expected behavior
Rovo Dev view should show "Welcome to Rovo Dev Beta"
Observed behavior
- Rovo Dev view keeps showing the "Add API Token" button.
- Output log contains "Unable to check Rovo Dev entitlement RovoDevEntitlementError: No valid Rovo Dev credentials found"
- globalStorage shows the site saved with
"isCloud":false
Environment and Version:
- Atlassian Plugin Version 4.1.62 and 4.0.11
- Visual Studio Code Version 1.106.3
- OS: Windows, Linux (WSL2)
Additional context
There seem to be places in the code where only URLs ending in '.atlassian.net' are considered to be cloud URLs, and '.jira.com' URLs are not considered. For example here:
atlascode/src/atlclients/loginManager.ts
Line 32 in 00541b2
| const CLOUD_TLD = '.atlassian.net'; |