Skip to content

Commit f55ce2a

Browse files
Assem-UberCopilot
andauthored
fix: History content negative z-index disallow clicks (#1069)
* fix content clicks Signed-off-by: Assem Hafez <assem.hafez@uber.com> * Update src/views/workflow-history/workflow-history.styles.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Signed-off-by: Assem Hafez <assem.hafez@uber.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 parent bcaca52 commit f55ce2a

File tree

3 files changed

+12
-4
lines changed

3 files changed

+12
-4
lines changed

src/views/workflow-history/workflow-history-header/workflow-history-header.styles.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ export const styled = {
2626
position: 'sticky',
2727
top: 0,
2828
boxShadow: $isSticky ? $theme.lighting.shallowBelow : 'none',
29+
zIndex: 1,
2930
},
3031
}),
3132
})

src/views/workflow-history/workflow-history.styles.ts

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,19 @@ import type {
44
} from '@/hooks/use-styletron-classes';
55

66
const cssStylesObj = {
7+
container: {
8+
display: 'flex',
9+
flexDirection: 'column',
10+
flex: 1,
11+
// This is to ensure the header section z-index is relative to this container and do not
12+
// show above external elements like popovers and modals
13+
position: 'relative',
14+
zIndex: 0,
15+
},
716
contentSection: {
817
display: 'flex',
918
flexDirection: 'column',
1019
flex: 1,
11-
// This is to ensure the content section is behind the header
12-
zIndex: -1,
1320
},
1421
eventsContainer: (theme) => ({
1522
display: 'flex',

src/views/workflow-history/workflow-history.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,7 @@ export default function WorkflowHistory({ params }: Props) {
316316
}
317317

318318
return (
319-
<>
319+
<div className={cls.container}>
320320
<WorkflowHistoryHeader
321321
isExpandAllEvents={isExpandAllEvents}
322322
toggleIsExpandAllEvents={toggleIsExpandAllEvents}
@@ -548,6 +548,6 @@ export default function WorkflowHistory({ params }: Props) {
548548
/>
549549
)}
550550
</PageSection>
551-
</>
551+
</div>
552552
);
553553
}

0 commit comments

Comments
 (0)