feat(vite-dev-server): migrate to async fs operations for better perf… #33024
+31
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormance - Replace fs.readFileSync with async fs.readFile - Add proper error handling with debug logs - Improve performance by avoiding event loop blocking - Remove TODO comment about async fs methods This follows Node.js best practices and improves DX with faster build times.
Collaborator
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…nction for lazy loading
… into feat/vite-async-fs
… into feat/vite-async-fs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ormance
This follows Node.js best practices and improves DX with faster build times.
Additional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Replaces sync file reads with async
fs/promises, adds a cached async loader forinitCypressTests.js, and updates HTML transform to await loader with debug/error handling.npm/vite-dev-server/src/plugins/cypress.ts):fstofs/promises; replace syncreadFileSyncwith asyncreadFile.loaderPromiseandgetLoaderPromise()wrappingloadInitFile()for one-time read ofINIT_FILEPATHwith retry-on-error behavior.transformIndexHtml:index.htmlvia asyncfs.readFile.<script>tags into<head>and append<script>${loader}</script>before</body>using awaited loader content.Written by Cursor Bugbot for commit 3b1d560. This will update automatically on new commits. Configure here.