Skip to content

Add required return types to MigrationsCollector for Symfony 8 compatibility #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
webignition wants to merge 3 commits into
base: 3.7.x
Choose a base branch
from
Open

Add required return types to MigrationsCollector for Symfony 8 compatibility #644

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84f4a47
Add void return type to MigrationsCollector::reset()
webignition Dec 1, 2025
cb64c1d
Add void return type to MigrationsCollector::collect()
webignition Dec 2, 2025
fdc007f
Add string return type to MigrationsCollector::getName()
webignition Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/Collector/MigrationsCollector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@
$this->flattener = $migrationsFlattener;
}

/** @return void */

Check failure on line 33 in src/Collector/MigrationsCollector.php

View workflow job for this annotation

GitHub Actions / Coding Standards / Coding Standards (PHP: 8.5) 

Method \Doctrine\Bundle\MigrationsBundle\Collector\MigrationsCollector::collect() has useless @return annotation.
public function collect(Request $request, Response $response, ?Throwable $exception = null)
public function collect(Request $request, Response $response, ?Throwable $exception = null): void

Check failure on line 34 in src/Collector/MigrationsCollector.php

View workflow job for this annotation

GitHub Actions / Coding Standards / Coding Standards (PHP: 8.5) 

Method \Doctrine\Bundle\MigrationsBundle\Collector\MigrationsCollector::collect() does not need documentation comment.
{
if ($this->data !== []) {
return;
Expand Down Expand Up @@ -76,8 +76,8 @@
$this->data['namespaces'] = $configuration->getMigrationDirectories();
}

/** @return string */

Check failure on line 79 in src/Collector/MigrationsCollector.php

View workflow job for this annotation

GitHub Actions / Coding Standards / Coding Standards (PHP: 8.5) 

Method \Doctrine\Bundle\MigrationsBundle\Collector\MigrationsCollector::getName() has useless @return annotation.
public function getName()
public function getName(): string

Check failure on line 80 in src/Collector/MigrationsCollector.php

View workflow job for this annotation

GitHub Actions / Coding Standards / Coding Standards (PHP: 8.5) 

Method \Doctrine\Bundle\MigrationsBundle\Collector\MigrationsCollector::getName() does not need documentation comment.
{
return 'doctrine_migrations';
}
Expand All @@ -88,8 +88,7 @@
return $this->data;
}

/** @return void */
public function reset()
public function reset(): void
{
$this->data = [];
}
Expand Down
Loading