[3.x] Drop deprecated features #2956
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IonBazan
force-pushed
the
drop-deprecated
branch
from
96223a6 to
0ba3c99
Compare
IonBazan
force-pushed
the
drop-deprecated
branch
from
0ba3c99 to
c6ed532
Compare
Copilot finished reviewing on behalf of
IonBazan
December 5, 2025 13:21
IonBazan
force-pushed
the
drop-deprecated
branch
2 times, most recently
from
da7be12 to
eb94490
Compare
There was a problem hiding this comment.
Pull request overview
This PR removes several deprecated features from the MongoDB ODM 3.x branch as part of a breaking change cleanup:
- Deprecated write concern options (
fsync,safe,w) LegacyReflectionFieldssupport in favor ofPropertyAccessors- NOTIFY change tracking policy support
indexesattribute property in document annotations- Combination of
targetDocumentwithdiscriminatorMap(now throws exception)
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/UnitOfWork.php |
Removed deprecated write concern options handling and NOTIFY change tracking logic |
src/Persisters/DocumentPersister.php |
Removed deprecated write concern option handling from write options |
src/PersistentCollection/PersistentCollectionTrait.php |
Removed NOTIFY change tracking support and needsSchedulingForSynchronization() method |
src/Mapping/LegacyReflectionFields.php |
Deleted entire legacy reflection fields implementation |
src/Mapping/Driver/AttributeDriver.php |
Removed handling of deprecated indexes attribute property |
src/Mapping/ClassMetadataFactory.php |
Removed deprecation warning for NOTIFY change tracking policy |
src/Mapping/ClassMetadata.php |
Removed LegacyReflectionFields properties and methods; changed targetDocument + discriminatorMap from deprecation to exception |
src/Mapping/MappingException.php |
Added new exception method for targetDocument + discriminatorMap combination |
src/Mapping/Annotations/File.php |
Removed deprecated indexes parameter from File annotation |
src/Mapping/Annotations/EmbeddedDocument.php |
Removed deprecated indexes parameter and constructor from EmbeddedDocument annotation |
src/Configuration.php |
Removed deprecated write concern options validation from configuration |
tests/Tests/Mapping/LegacyReflectionFieldsTest.php |
Deleted test file for removed LegacyReflectionFields feature |
tests/Tests/Mapping/ClassMetadataTest.php |
Removed assertion checking for LegacyReflectionFields instance |
Comments suppressed due to low confidence (1)
src/PersistentCollection/PersistentCollectionTrait.php:741
- The
needsSchedulingForSynchronization()method is being removed, but it's still referenced inDefaultPersistentCollectionGenerator::generateMethod()at line 199. This will cause a fatal error when generated persistent collection classes try to call this non-existent method. The generator code should also be updated to remove the call to this method.
/**
* @phpstan-param Closure(TKey, T):bool $p
*
* @phpstan-return T|null
*/
public function findFirst(Closure $p): ?object
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
IonBazan
force-pushed
the
drop-deprecated
branch
from
eb94490 to
9ae4c98
Compare
GromNaN
reviewed
Dec 5, 2025
IonBazan
force-pushed
the
drop-deprecated
branch
from
9ae4c98 to
7288293
Compare
IonBazan
force-pushed
the
drop-deprecated
branch
from
7288293 to
cb78c45
Compare
IonBazan
commented
Dec 5, 2025
| $metadata->addLifecycleCallback('doStuffOnPrePersist', 'prePersist'); | ||
| $metadata->addLifecycleCallback('doOtherStuffOnPrePersistToo', 'prePersist'); | ||
| $metadata->addLifecycleCallback('doStuffOnPostPersist', 'postPersist'); | ||
| $metadata->setDiscriminatorField(['fieldName' => 'discr']); |
Member
Author
There was a problem hiding this comment.
I found that this loadMetadata() method is not even called - all tests were passing without TypeError thrown, when I left it like that.
Perhaps we can remove this method completely.
Member
There was a problem hiding this comment.
Yes, it can be removed here and from the 2.x branch.
Member
There was a problem hiding this comment.
It looks like a aborted attempt to use StaticPHPDriver https://github.com/doctrine/persistence/blob/f7deb2207f44cd2cd30a59bec3d2451738848af6/docs/en/reference/index.rst#staticphpdriver
Member
Author
There was a problem hiding this comment.
I think we can leave it for now and try to cover it with a different test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes some features marked as deprecated:
fsync,safeandwwrite concernsindexesattribute propertyLegacyReflectionFieldssupportNOTIFYchange tracking policy supporttargetDocumentwithdiscriminatorMapwill now trigger exception.setDiscriminatorField