Skip to content

Conversation

@dbu
Copy link
Member

@dbu dbu commented Dec 4, 2025

fix #878

@dbu dbu mentioned this pull request Dec 4, 2025
@dbu
Copy link
Member Author

dbu commented Dec 4, 2025

uh. this will need a new major version. a couple of BC breaks on the interfaces are necessary.

@loic425
Copy link
Contributor

loic425 commented Dec 4, 2025

Ok, take your time, but indeed, a new major version is necessary. Fo the packages I maintain, ODM packages are just optional, so I don't need this quickly.

@loic425 loic425 mentioned this pull request Dec 4, 2025
7 tasks
@dbu dbu changed the base branch from 2.1.x to 3.0.x December 4, 2025 10:09
@dbu dbu force-pushed the persistence-4 branch 3 times, most recently from b809269 to f8f438e Compare December 4, 2025 10:40
@dbu
Copy link
Member Author

dbu commented Dec 4, 2025

@rela589n i created this to see what all fails. there is quite some things. if you feel up to it, separate pull requests to continue aligning the phpcr codebase are very appreciated.

so far one significant issue seems to be that persistence returns array on findAll / findMany, while we returned a Collection. this only shows now because of strict typing, it was a mismatch before that too, from what i can tell.

@rela589n
Copy link

rela589n commented Dec 4, 2025

Hi, @dbu !

issue that persistence returns array on findAll / findMany

Yeah, that's the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants