Fix null refs when calling GetLocation() or GetDiagnostics() of freshly constructed syntax trivia
#81444
+28
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
Community
CyrusNajmabadi
approved these changes
Nov 25, 2025
Member
CyrusNajmabadi
left a comment
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
Yup. Seems to match SyntaxToken now.
CyrusNajmabadi
approved these changes
Nov 25, 2025
Member
CyrusNajmabadi
left a comment
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
Yup. Seems to match SyntaxToken now.
Contributor
Author
|
Can I have a review here please?! |
AlekseyTs
reviewed
Dec 3, 2025
| { | ||
| // https://github.com/dotnet/roslyn/issues/40773 | ||
| return this.SyntaxTree!.GetDiagnostics(this); | ||
| return this.SyntaxTree?.GetDiagnostics(this) ?? SpecializedCollections.EmptyEnumerable<Diagnostic>(); |
Contributor
Contributor
Consider making the title more detailed. For example by mentioning what APIs are getting fixed/changed |
Contributor
|
Done with review pass (commit 1) |
DoctorKrolic
changed the title
GetLocation() or GetDiagnostics() of freshly constructed syntax trivia
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #40773
Matches behavior of syntax token in test above