Add implementation for JVM_CopyOfSpecialArray #23007
Conversation
theresa-m
added
comp:vm
project:valhalla
|
Please open a pull request to remove test/jdk/java/lang/invoke/BigArityTest.java from https://github.com/adoptium/aqa-tests/blob/master/openjdk/excludes/ProblemList_openjdkvalhalla-openj9.txt once this change is merged. |
runtime/j9vm/valhallavmi.cpp
Outdated
| { | ||
| assert(!"JVM_CopyOfSpecialArray unimplemented"); | ||
| return NULL; | ||
| j9object_t origObj; |
There was a problem hiding this comment.
Initialize these variables to null or 0.
| J9VMThread *currentThread = (J9VMThread *)env; | ||
| J9InternalVMFunctions *vmFuncs = currentThread->javaVM->internalVMFunctions; | ||
| vmFuncs->internalEnterVMFromJNI(currentThread); | ||
|
|
runtime/j9vm/valhallavmi.cpp
Outdated
| vmFuncs->internalEnterVMFromJNI(currentThread); | ||
|
|
||
|
|
||
| if (orig == NULL) { |
There was a problem hiding this comment.
When comparing a variable to a constant put the constant on the left as per our coding standards.
runtime/j9vm/valhallavmi.cpp
Outdated
|
|
||
| if (NULL == orig) { | ||
| vmFuncs->setCurrentException(currentThread, J9VMCONSTANTPOOL_JAVALANGNULLPOINTEREXCEPTION, NULL); | ||
| vmFuncs->internalExitVMToJNI(currentThread); |
There was a problem hiding this comment.
Instead of having multiple return points that need to make this call I recommend jumping to a label similar to what is done in newArrayHelper in this file.
runtime/j9vm/valhallavmi.cpp
Outdated
| } | ||
| origObj = J9_JNI_UNWRAP_REFERENCE(orig); | ||
| origClass = J9OBJECT_CLAZZ(currentThread, origObj); | ||
| componentClass = ((J9ArrayClass *)origClass)->leafComponentType; |
There was a problem hiding this comment.
I don't see that the componentClass is used anywhere.
| origClass = J9OBJECT_CLAZZ(currentThread, origObj); | ||
| componentClass = ((J9ArrayClass *)origClass)->leafComponentType; | ||
| origLength = J9INDEXABLEOBJECT_SIZE(currentThread, origObj); | ||
| if (from < 0 || to > (jint)origLength || from > to) { |
There was a problem hiding this comment.
Add parenthesis around each statement.
| componentClass = ((J9ArrayClass *)origClass)->leafComponentType; | ||
| origLength = J9INDEXABLEOBJECT_SIZE(currentThread, origObj); | ||
| if (from < 0 || to > (jint)origLength || from > to) { | ||
| vmFuncs->setCurrentException(currentThread, J9VMCONSTANTPOOL_JAVALANGARRAYINDEXOUTOFBOUNDSEXCEPTION, NULL); |
There was a problem hiding this comment.
Does the ri throw ArrayIndexOutOfBoundsException for from > to as well?
There was a problem hiding this comment.
It throws IllegalArgumentException if from >= to. Will change it.
| JNIEXPORT jarray JNICALL | ||
| JVM_CopyOfSpecialArray(JNIEnv *env, jarray orig, jint from, jint to) | ||
| { | ||
| assert(!"JVM_CopyOfSpecialArray unimplemented"); |
There was a problem hiding this comment.
I just noticed there is a copyFlattenableArray method in ValueTypeHelpers.hpp. Can this method be reused here?
There was a problem hiding this comment.
I feel that the copyFlattenableArray method can’t be used here because it requires a special Valhalla stack frame to be built before the call. I’m not sure how the frame could be constructed from here.
Related: eclipse-openj9#22642 Add the implementation for method JVM_CopyOfSpecialArray
2 participants
Related: #22642
Add the implementation for method JVM_CopyOfSpecialArray
With this change
test/jdk/java/lang/invoke/BigArityTest.javapasses.