Error with string formatting

[laulaz]

When trying to render an error message, mr.developer fails:

mr.developer: Updated 'my.package' with git.
Traceback (most recent call last):
  File "mr.develope/mr/developer/common.py", line 181, in worker
    for lvl, msg in wc._output:
ValueError: too many values to unpack

This is because of wrong string formatting:
self.output((logger.info, "No such branch %r", branch))

I saw several of those, but didn't check all of them yet.

[fschulze]

This isn't wrong string formatting, see https://docs.python.org/3/howto/logging.html#logging-variable-data (I think the main reason the formatting isn't done right away is for performance, if the string doesn't need to be output, the formatting can be skipped, which makes a huge difference in quite a lot of cases)

But the handling in common.py needs to be fixed to support the arguments.

[laulaz]

👍