TreeDataGrid Support

[GallaFrancesco]

Are there any plans to support TreeDataGrid in FuncUI?

It should be possible to use it in place of DataGrid with the additional benefits of having TreeView on top and other perks such as SelectableTextBlock by default on DataGridTextColumn.

[Numpsy]

I've been making some simple use of it in a FuncUI application and there could be some 'official' bindings for it, though I don't think the core library should depend on it.

[GallaFrancesco]

Why not? The DataGrid control is supported and it's managed by the Avalonia organization as well. I know TreeDataGrid is a separate package but technically DataGrid is as well, even though the sources are in the AvaloniaUI repo https://github.com/AvaloniaUI/Avalonia/blob/master/src/Avalonia.Controls.DataGrid/DataGrid.cs

[JaggerJo]

Would you contribute the bindings?

I'm not entirely happy with how we included the bindings for data grid in the main library. This creates a transitive dependency on Avalonia.Controls.DataGrid for all projects referencing FuncUI.

We should have small binding packages for control libraries.

[Numpsy]

TreeDataGrid also has a dependency on System.Reactive, which is quite large itself, so I don't think forcing a dependency is ideal (not my descision of course)

[JaggerJo]

TreeDataGrid also has a dependency on System.Reactive, which is quite large itself, so I don't think forcing a dependency is ideal (not my descision of course)

💯 agreed.

[Numpsy]

Hmm, had a look at my usage of TreeDataGrid and it's basically all code behind style and no real bindings - e.g. doing things like

let makeTreeDataSource initialItems =
    let gridSauce =
        new HierarchicalTreeDataGridSource<StructuredSectionContent>(items = initialItems)

    gridSauce.Columns.Add(
        HierarchicalExpanderColumn<StructuredSectionContent>(
            TextColumn<StructuredSectionContent, string>("Name", (fun section -> section.DisplayName)),
            (fun x -> x.SubSections),
            (fun x -> not (Seq.isEmpty x.SubSections))
        )
    )

    gridSauce.Columns.Add(
        TextColumn<StructuredSectionContent, string>("Value", (fun section -> section.DisplayValue))
    )

    gridSauce

and then just assigning that to the Source property of the grid in an init function.

[Numpsy]

fwiw, there's a discussion at AvaloniaUI/Avalonia#16997 about relicensing TreeDataGrid with a dual license AGPL-3 / Commercial license, and I think that itself would rule out having the main libraries here depend on it?

[Numpsy]

So, is it worth adding some bindings like master...Numpsy:Avalonia.FuncUI:treedatagrid to an extra library

[Numpsy]

Would you contribute the bindings?

I'm not entirely happy with how we included the bindings for data grid in the main library. This creates a transitive dependency on Avalonia.Controls.DataGrid for all projects referencing FuncUI.

We should have small binding packages for control libraries.

As Avalonia 12 is coming up and possibly gives some scope for breaking changes, and given that DataGrid itself has been broken out of the main Avalonia repository into its own self contained one, what are the thoughts in breaking the FuncUI bindings out and having separate packages for DataGrid and TreeDataGrid?

[JaggerJo]

Would you contribute the bindings?
I'm not entirely happy with how we included the bindings for data grid in the main library. This creates a transitive dependency on Avalonia.Controls.DataGrid for all projects referencing FuncUI.
We should have small binding packages for control libraries.

As Avalonia 12 is coming up and possibly gives some scope for breaking changes, and given that DataGrid itself has been broken out of the main Avalonia repository into its own self contained one, what are the thoughts in breaking the FuncUI bindings out and having separate packages for DataGrid and TreeDataGrid?

I'm all for it 👍

One thing to consider is that AvaloniaUI owns the NuGet namespace Avalonia.*. Access to Avalonia.FuncUI packages needs to be granted package by package.

We can either:

• reach out the Avalonia Team and do the same for the new package
• establish a new repository for community bindings (I assume there could be a lot of community maintained bindings if we'd simplify it)

[Numpsy]

Except now the original TreeDataGrid repo has been archived because noone wants to maintain it, and the Avalonia replacement is part of the paid accelerate program. (The question about a separate DataGrid package still stands though)