Skip to content

Comments aren't allowed in env_vars and secrets #590

@mbrevda

Description

@mbrevda

TL;DR

The docs show:

with:
  secrets: |-
    # As an environment variable:
    KEY1=secret-key-1:latest

This leads to the impression that a comment is allowed in (what looks like) a YAML map, although this actually parsed as a string and fails (the comments end up as part of the keys).

Having comments is very helpful when the list gets long.

Expected behavior

The list should be parsed as a map. Or perhaps this should conditionally try to parse the list as a map and only fall back to parsing if it's a string.

Observed behavior

No response

Action YAML

env_vars: >
  #app vars
  APP_VERSION: 1

Log output

It's long and needs lots of redaction... going to hold on this unless absolutely necessary

Additional information

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions