Patcher fatals silently ignored

[kkmuffme]

Bug report

Question	Answer
PHP-Scoper version	0.18.18

#869 deprecated --stop-on-failure
Because the scoper catches all execptions and logs them https://github.com/humbug/php-scoper/blob/main/src/Console/ConsoleScoper.php#L356 only if OutputInterface::VERBOSITY_VERY_VERBOSE (-vv) this means that if there's an exception in a patcher, the execption is silently "swallowed" and the file not scoped.

However using -vv isn't practiable, since it includes tons of other, non-error and useless output.

Therefore, I suggest:

• In terms of usability, and to stay closely to PHP's original behavior, I think it would make a lot of sense if the default behavior of outputWarnOfFailure is to always print exceptions - remove https://github.com/humbug/php-scoper/blob/main/src/Console/ScoperLogger.php#L125 condition at least for any exceptions that are not from within scoper itself
• undeprecate --stop-on-failure to allow complex patcher set ups to handle exceptions in their own (PHP defined/native exception handler)

[theofidry]

undeprecate --stop-on-failure to allow complex patcher set ups to handle exceptions in their own (PHP defined/native exception handler)

It's been a while so maybe I remember incorrectly, but from #869 --stop-on-failure is been deprecated because the behaviour was changed to make it behave as if this flag was always here, and instead introduced --continue-on-failure.

remove https://github.com/humbug/php-scoper/blob/main/src/Console/ScoperLogger.php#L125 condition at least for any exceptions that are not from within scoper itself

That should already be the case: this is only for ParsingException which is thrown on PhpParserError, unless I missed another try/catch somewhere.

---

The overall issue does not make much sense to me, but it is also clear you've encountered a case that does not make sense from the user perspective.

It's always easier to get a few things mixed up when in the middle of a project, and some pieces here are also quite old to me so I do not have it fresh in my mind either. Would you mind providing a small reproducer that would showcase this problem? This would allow us to start this conversation on a clean base and ensure we tackle the real problem.

[sebastianbergmann]

if there's an exception in a patcher, the execption is silently "swallowed" and the file not scoped

It's worse than that as it does not need to be a real error in a patcher as can be seen in #1139.