Skip to content

Commit 3b1b4c9

Browse files
committed
point zig directly to cached libc_v8.a
1 parent 267213e commit 3b1b4c9

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

.github/workflows/build.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838
arch: ${{env.ARCH}}
3939

4040
- name: zig build
41-
run: zig build -Dprebuilt_v8_path=v8 -Doptimize=ReleaseSafe -Dcpu=x86_64 -Dgit_commit=$(git rev-parse --short ${{ github.sha }})
41+
run: zig build -Dprebuilt_v8_path=v8/libc_v8.a -Doptimize=ReleaseSafe -Dcpu=x86_64 -Dgit_commit=$(git rev-parse --short ${{ github.sha }})
4242

4343
- name: Rename binary
4444
run: mv zig-out/bin/lightpanda lightpanda-${{ env.ARCH }}-${{ env.OS }}
@@ -76,7 +76,7 @@ jobs:
7676
arch: ${{env.ARCH}}
7777

7878
- name: zig build
79-
run: zig build -Dprebuilt_v8_path=v8 -Doptimize=ReleaseSafe -Dcpu=generic -Dgit_commit=$(git rev-parse --short ${{ github.sha }})
79+
run: zig build -Dprebuilt_v8_path=v8/libc_v8.a -Doptimize=ReleaseSafe -Dcpu=generic -Dgit_commit=$(git rev-parse --short ${{ github.sha }})
8080

8181
- name: Rename binary
8282
run: mv zig-out/bin/lightpanda lightpanda-${{ env.ARCH }}-${{ env.OS }}
@@ -116,7 +116,7 @@ jobs:
116116
arch: ${{env.ARCH}}
117117

118118
- name: zig build
119-
run: zig build -Dprebuilt_v8_path=v8 -Doptimize=ReleaseSafe -Dgit_commit=$(git rev-parse --short ${{ github.sha }})
119+
run: zig build -Dprebuilt_v8_path=v8/libc_v8.a -Doptimize=ReleaseSafe -Dgit_commit=$(git rev-parse --short ${{ github.sha }})
120120

121121
- name: Rename binary
122122
run: mv zig-out/bin/lightpanda lightpanda-${{ env.ARCH }}-${{ env.OS }}
@@ -159,7 +159,7 @@ jobs:
159159
arch: ${{env.ARCH}}
160160

161161
- name: zig build
162-
run: zig build -Dprebuilt_v8_path=v8 -Doptimize=ReleaseSafe -Dgit_commit=$(git rev-parse --short ${{ github.sha }})
162+
run: zig build -Dprebuilt_v8_path=v8/libc_v8.a -Doptimize=ReleaseSafe -Dgit_commit=$(git rev-parse --short ${{ github.sha }})
163163

164164
- name: Rename binary
165165
run: mv zig-out/bin/lightpanda lightpanda-${{ env.ARCH }}-${{ env.OS }}

.github/workflows/e2e-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ jobs:
5858
- uses: ./.github/actions/install
5959

6060
- name: zig build release
61-
run: zig build -Dprebuilt_v8_path=v8 -Doptimize=ReleaseFast -Dcpu=x86_64 -Dgit_commit=$(git rev-parse --short ${{ github.sha }})
61+
run: zig build -Dprebuilt_v8_path=v8/libc_v8.a -Doptimize=ReleaseFast -Dcpu=x86_64 -Dgit_commit=$(git rev-parse --short ${{ github.sha }})
6262

6363
- name: upload artifact
6464
uses: actions/upload-artifact@v4

.github/workflows/zig-test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ jobs:
5656
- uses: ./.github/actions/install
5757

5858
- name: zig build debug
59-
run: zig build -Dprebuilt_v8_path=v8
59+
run: zig build -Dprebuilt_v8_path=v8/libc_v8.a
6060

6161
- name: upload artifact
6262
uses: actions/upload-artifact@v4
@@ -104,7 +104,7 @@ jobs:
104104
- uses: ./.github/actions/install
105105

106106
- name: zig build test
107-
run: zig build -Dprebuilt_v8_path=v8 test -- --json > bench.json
107+
run: zig build -Dprebuilt_v8_path=v8/libc_v8.a test -- --json > bench.json
108108

109109
- name: write commit
110110
run: |

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ RUN case $TARGETPLATFORM in \
5454
mv libc_v8.a v8/libc_v8.a
5555

5656
# build release
57-
RUN zig build -Doptimize=ReleaseSafe -Dprebuilt_v8_path=v8 -Dgit_commit=$$(git rev-parse --short HEAD)
57+
RUN zig build -Doptimize=ReleaseSafe -Dprebuilt_v8_path=v8/libc_v8.a -Dgit_commit=$$(git rev-parse --short HEAD)
5858

5959
FROM debian:stable-slim
6060

0 commit comments

Comments
 (0)