-
-
Notifications
You must be signed in to change notification settings - Fork 492
fix: Enable provide with stateful callable and cleanup #4459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: Enable provide with stateful callable and cleanup #4459
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4459 +/- ##
=======================================
Coverage 97.83% 97.83%
=======================================
Files 296 296
Lines 15295 15300 +5
Branches 1713 1714 +1
=======================================
+ Hits 14964 14969 +5
Misses 189 189
Partials 142 142 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Janek Nouvertné <provinzkraut@posteo.de>
|
Hi @provinzkraut , thanks for your review, that was an obvious oversight on my end. I commited as per your suggestion and the PR should be ready to merge :) |
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/4459 |
|
Hey @provinzkraut , any chance we can move on with this PR? :) |
Description
Fix the Provide class for callable class instances returning an (Async) Generator.
Closes #4457