Remove crossorigin from preload hints for same-origin vendor assets #304
+8
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vendor assets are served from /vendor/... (same origin), so crossorigin attribute on preload hints causes a credentials mode mismatch. The browser preloads with anonymous credentials but requests without, resulting in cache misses and double fetching.
✅ Deploy Preview for lodash ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jonchurch
commented
Dec 5, 2025
| hints: | ||
| all: [ | ||
| '</sw.js>; rel=serviceworker', | ||
| '<https://cdn.jsdelivr.net/>; rel=preconnect; pr=1.0; crossorigin', |
Member
Author
There was a problem hiding this comment.
we just dont use anything from jsdeliver directly anymore, we serve under our own origin
UlisesGascon
approved these changes
Dec 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vendor assets are served from /vendor/... (same origin), so crossorigin attribute on preload hints causes a credentials mode mismatch. The browser preloads with anonymous credentials but requests without, resulting in cache misses and double fetching.
opened as draft so I can compare the deploy preview to the prod site console warnings, check my math basically
On the prod site I see a warning on the homepage:
And on the /docs route after hard refresh we see:
This PR eliminates those warnings.