-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: reduced overrides #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🚀 Performance Benchmark Results
✅ All benchmarks passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the project's dependency management by removing most pnpm overrides from package.json, keeping only the critical @eslint/plugin-kit@<0.3.4 override. The refactoring aims to simplify dependency management and allow pnpm to resolve dependencies more naturally, but results in several transitive dependency version changes.
- Removes 6 out of 7 pnpm override rules for dependencies like
tmp,vite,js-yaml, andglob - Retains only the essential
@eslint/plugin-kitsecurity override - Results in lockfile changes including some dependency downgrades
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Removed 6 out of 7 pnpm override rules, keeping only the @eslint/plugin-kit@<0.3.4 override |
| pnpm-lock.yaml | Reflects dependency resolution changes from removed overrides, including downgrades of js-yaml (4.1.1 → 3.14.2) and @eslint/plugin-kit (0.5.0 → 0.4.1), plus removal of unused packages and peer dependency adjustments |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
| dependencies: | ||
| graceful-fs: 4.2.11 | ||
| js-yaml: 4.1.1 | ||
| js-yaml: 3.14.2 |
Copilot
AI
Dec 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the js-yaml overrides has caused a transitive dependency (read-yaml-file@1.1.0) to downgrade from js-yaml@4.1.1 to js-yaml@3.14.2. While 3.14.2 is the minimum safe version that addresses CVE-2021-21434, version 4.1.1 is newer and has additional security improvements and bug fixes. Consider keeping the js-yaml@>=4.0.0 <4.1.1: '>=4.1.1' override to ensure dependencies use the latest secure version when on the 4.x line.
| '@babel/helper-validator-identifier': 7.28.5 | ||
| '@eslint-community/eslint-utils': 4.9.0(eslint@9.39.1(jiti@2.6.1)) | ||
| '@eslint/plugin-kit': 0.5.0 | ||
| '@eslint/plugin-kit': 0.4.1 |
Copilot
AI
Dec 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the overrides has caused eslint-plugin-unicorn to downgrade from using @eslint/plugin-kit@0.5.0 to @eslint/plugin-kit@0.4.1. While 0.4.1 still meets the minimum override requirement of >=0.3.4, you should verify that this downgrade doesn't introduce compatibility issues or missing features that eslint-plugin-unicorn may need.
Description
reduce configured
pnpmoverridesType of Change
Testing
Checklist
Browser Testing
If applicable, please test in the following browsers:
Performance Impact
If this change affects performance:
Breaking Changes
If this introduces breaking changes, please describe:
Additional Notes
Any additional information that reviewers should know.