Skip to content

Conversation

@mfranzke
Copy link
Owner

@mfranzke mfranzke commented Dec 6, 2025

Description

reduce configured pnpm overrides

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Code refactoring

Testing

  • Tests pass locally
  • Added tests for new functionality
  • Updated existing tests
  • Manual testing completed

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Browser Testing

If applicable, please test in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge

Performance Impact

If this change affects performance:

  • I have run performance benchmarks
  • Performance impact is documented
  • Performance regression is acceptable for the added functionality

Breaking Changes

If this introduces breaking changes, please describe:

Additional Notes

Any additional information that reviewers should know.

@mfranzke mfranzke self-assigned this Dec 6, 2025
Copilot AI review requested due to automatic review settings December 6, 2025 22:04
@mfranzke mfranzke added the dependencies Pull requests that update a dependency file label Dec 6, 2025
@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2025

⚠️ No Changeset found

Latest commit: 5cdd7e3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2025

🚀 Performance Benchmark Results

Metric Value Status
Initialization Time 0.30ms
Avg Processing Time 0.2756ms
Total Processing Time (1000x) 275.60ms ℹ️

✅ All benchmarks passed!

@mfranzke mfranzke merged commit e6fc81c into main Dec 6, 2025
29 checks passed
@mfranzke mfranzke deleted the refactor-reduced-overrides branch December 6, 2025 22:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the project's dependency management by removing most pnpm overrides from package.json, keeping only the critical @eslint/plugin-kit@<0.3.4 override. The refactoring aims to simplify dependency management and allow pnpm to resolve dependencies more naturally, but results in several transitive dependency version changes.

  • Removes 6 out of 7 pnpm override rules for dependencies like tmp, vite, js-yaml, and glob
  • Retains only the essential @eslint/plugin-kit security override
  • Results in lockfile changes including some dependency downgrades

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.

File Description
package.json Removed 6 out of 7 pnpm override rules, keeping only the @eslint/plugin-kit@<0.3.4 override
pnpm-lock.yaml Reflects dependency resolution changes from removed overrides, including downgrades of js-yaml (4.1.1 → 3.14.2) and @eslint/plugin-kit (0.5.0 → 0.4.1), plus removal of unused packages and peer dependency adjustments
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

dependencies:
graceful-fs: 4.2.11
js-yaml: 4.1.1
js-yaml: 3.14.2
Copy link

Copilot AI Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the js-yaml overrides has caused a transitive dependency (read-yaml-file@1.1.0) to downgrade from js-yaml@4.1.1 to js-yaml@3.14.2. While 3.14.2 is the minimum safe version that addresses CVE-2021-21434, version 4.1.1 is newer and has additional security improvements and bug fixes. Consider keeping the js-yaml@>=4.0.0 <4.1.1: '>=4.1.1' override to ensure dependencies use the latest secure version when on the 4.x line.

Copilot uses AI. Check for mistakes.
'@babel/helper-validator-identifier': 7.28.5
'@eslint-community/eslint-utils': 4.9.0(eslint@9.39.1(jiti@2.6.1))
'@eslint/plugin-kit': 0.5.0
'@eslint/plugin-kit': 0.4.1
Copy link

Copilot AI Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the overrides has caused eslint-plugin-unicorn to downgrade from using @eslint/plugin-kit@0.5.0 to @eslint/plugin-kit@0.4.1. While 0.4.1 still meets the minimum override requirement of >=0.3.4, you should verify that this downgrade doesn't introduce compatibility issues or missing features that eslint-plugin-unicorn may need.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants