-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Adding Visual Studio 18.0 #21412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Adding Visual Studio 18.0 #21412
Conversation
|
Thanks @andysterland for getting this started -- change looks good to me. As we discussed in chat I think this is overly engineering with specific string-looking rather than really relying on |
|
This SqlAzureDacpacDeploymentV1 Task also looks up the presence of VS:
|
|
And I suspect it should target the https://github.com/microsoft/azure-pipelines-tasks/blob/master/Tasks/MSBuildV1/task.json#L57-L65 Which requires updating: |
|
Similar to the comment from @jessehouwing , then I believe that also |
Thanks for pointing that out :). Looking into that file a bit more. It looks like making a change across the board in that file is probably best once VS2026 is released as it looks like that file checks for |
Added. |
|
@timheuer @ToreDemant @jessehouwing Thanks for looking at this PR :). I was thinking of holding off merging until VS2026 releases. |
|
@andysterland These tasks have never supported prerelease/insider release som maybe it is not the biggest problem if they don't after this change either. Perhaps changing the title and description to mention 'Visual Studio 18.0 GA' I do however agree that it would be preferrable if that support could be added too, in another PR of cause. Perhaps it could be done like the environment knob in Azure Pipeline Agent called |
|
It seems that the node module Any idea on how/where that can be updated? |
I think @jessehouwing pointed out they come from: https://github.com/microsoft/azure-pipelines-tasks-common-packages/tree/main/common-npm-packages/msbuildhelpers Started a draft PR for that at: microsoft/azure-pipelines-tasks-common-packages#506 |
|
Arh, of cause, @jessehouwing is as always one step ahead :-) |
|
@andysterland there seem to still be picklists missing from this PR. These are the ones I found:
I found these places by searching for '17' and '2022' as I figured that if they are there then there probably also need to be something for '18' or '2026'. |
I'll take that as a compliment. I'll make sure the task is available for Azure DevOps Server |
|
@andysterland should we convert this to a full PR and just request not merge until release? |
|
@timheuer / @andysterland I believe that some changes are still needed - see my comment above. ... and the following changes in Azure Pipeline Tasks Common Packages are also needed: |
Created a PR for that: microsoft/azure-pipelines-tasks-common-packages#506 |
|
A merge would be 100% appreciated. We have been blocked from builds in DevOps since the 11th because we need MSBuild/2026 support. I have a workaround by keeping an older version of VS on the build machine, but I'd rather move forward as the majority of our systems have been updated to .NET 10 and 4.8.1 |
@jhudsonWA or by updating your pipelines to point at the exe files location directly: |
Co-authored-by: Jesse Houwing <jesse.houwing@gmail.com>
Co-authored-by: Jesse Houwing <jesse.houwing@gmail.com>
I left that out on purpose as Xamarin is not supported in VS2026 and the component is not included. I assume folk wanting to build Xamarin apps will need to use earlier versions of the tools. |
Arh, that is correct. Perhaps add a comment in the code about that to avoid someone trying to add it later |
|
Hi all, Any update to this that will push it over the finish line? :) |
|
@snickler I am also waiting in excitement but I believe that the following needs to be finished first so its package can be included here. |
|
@andysterland the changes in Azure Pipelines Tasks Common Packages have now been merged into main, so I wonder if this PR could be resumed. |
|
@sanjays-ms is there a plan for integrating the updated azure-pipelines-tasks-common-packages from your PR into this one so that the task can be concluded? |
@timheuer do you know the status on this PR. It would be mighty good to finish it up and get it merged. |
|
@chrisbardon Not saying it's a good workaround, but it is a work-around nonetheless. |
|
@durandt , I saw that comment, but the challenge is that I'm using vsbuild (not msbuild) in all of my pipelines, and I'd rather not have to go through and update all of them (and then revert once this works properly). |
|
@tarunramsinghani MSBuild and VSBuild was fixed, but what about the rest of the tasks addressed here? |
|
Is this PR obsolete because #21476 is already merged? |
|
Should this PR just be abandoned? I'm fine with that, I haven't had the time I had hoped for to look at this. |
|
IMHO yes. It looks like the other PR's are from repo team members and will most likely be the one's to get merged |
|
However, #21508 only contains fixes for V3 and not V2 |


Context
Adding VS2026 to the VSBuild@1 task so it can be used as soon the GA release of VS2026 becomes available.
Important This task uses VSWhere to determine what versions of Visual Studio are installed. VSWhere won't find VS2026 Insiders without the
-prereleaseflag. This will cause issues wherever it's assumed-latestwill return18.0. Ergo it might be best to not update this task until VS2026 is GA as plumping through-prereleaseis a much bigger change.#21319
Task Name
VSBuildV1
Description
Adding Visual Studio 2026, 18.0, to the hardcoded list of versions that are available.
Risk Assessment (Low / Medium / High)
Low
Change Behind Feature Flag (Yes / No)
No.
Tech Design / Approach
Copy of the commit 1ab60be and 41450699102924f215268bff661191afe9fe6c3d5703d3a7473db7e4293a2950 that added VS2022 but with +1 on versions :).
Documentation Changes Required (Yes/No)
Yes. Documentation needs to be updated to include 18.0 as a valid version.
Unit Tests Added or Updated (Yes / No)
No
Additional Testing Performed
Logging Added/Updated (Yes/No)
No, no change required updated logging.
Telemetry Added/Updated (Yes/No)
No. The task has no telemetry.
Rollback Scenario and Process (Yes/No)
Dependency Impact Assessed and Regression Tested (Yes/No)
Checklist