Skip to content

Fix / Redesign Theme Overall usage in New Arch #702

@anupriya13

Description

@anupriya13

Fix Theme Overall design in New Arch, check for reference:
image

This is the flow currently. The bug is in the useTheme which is set as default but should be as per the themecontext
image

ans useTheme is used in 70+ code files already:
image

Also some places PlatformColor is used https://github.com/search?q=repo%3Amicrosoft%2Freact-native-gallery+platformcolor&type=code

refer https://github.com/microsoft/react-native-windows/blob/d9bd9b2d9125dca833c7b1268f4f0497e95c79a3/vnext/Microsoft.ReactNative/Fabric/Composition/Theme.cpp#L242

All code in theme should follow PlatformColor not hardcoded strings in js

Image

especially in these files:

https://github.com/microsoft/react-native-gallery/blob/main/NewArch/src/themes/LightTheme.tsx
https://github.com/microsoft/react-native-gallery/blob/main/NewArch/src/themes/DarkTheme.tsx
https://github.com/microsoft/react-native-gallery/blob/main/NewArch/src/themes/HighContrastTheme.tsx

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions