Skip to content
This repository was archived by the owner on Jun 8, 2025. It is now read-only.

add support for multiple services #1

Open
wardviaene wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add support for multiple services #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lambda_function.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,5 +65,7 @@ def lambda_handler(event, context):

# Valid event, and one we are interested in
cluster = event["detail"]["clusterArn"]
adjust_service_desired_count(ecs_client(), cluster, service)
serviceItems = service.split(',')
Copy link
Owner

@miketheman miketheman Aug 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remain consistent with the python naming convention of lower_case_with_underscores for variables.

for item in serviceItems[:]:
Copy link
Owner

@miketheman miketheman Aug 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unfamiliar with the syntax of serviceItems[:] - can you explain how that is different from for item in serviceItems:?

adjust_service_desired_count(ecs_client(), cluster, item)
print("DONE")