Fixed fullscreen rendering y-direction mouse offset issue on Mac OS devices with camera notch #456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where m_flMouseYScale was incorrectly calculated in fullscreen mode for devices with display-integrated camera notch on Mac OS.
With the improper m_flMouseYScale value, clicking on menu items, buttons, etc. meant that you had to aim below the actual button, etc.
In the fix, SDL_GL_GetDrawableSize is used to get the proper drawable area.
Tested on Mac OS on an MacBook Air M2. Works for all offered resolutions, windowed and fullscreen.