Skip to content

[v24.x][riscv] Fix check failed in bind_to #60962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kxxt wants to merge 2 commits into
base: v24.x-staging
Choose a base branch
from
Open

[v24.x][riscv] Fix check failed in bind_to #60962

kxxt wants to merge 2 commits into from
+27 −9

Conversation

@kxxt
Copy link
Contributor

@kxxt kxxt commented Dec 5, 2025

Backport two V8 commits to fix a crash found while building Adguard Home using webpack riscv-forks/electron#9.

This is only needed for v24.x.

The PR for the main branch(#58746) has missed its opportunity because now v8 version on v25.x and main already contains these fixes.

Close #60895

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 5, 2025

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. v8 engine Issues and PRs related to the V8 dependency. labels Dec 5, 2025
@kxxt kxxt mentioned this pull request Dec 5, 2025
Open
9 tasks
@richardlau richardlau linked an issue Dec 5, 2025 that may be closed by this pull request
[RISCV] Check failed: (trampoline_pos - fixup_pos) <= kMaxBranchOffset. #60895
Open
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 5, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 5, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 5, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70392/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 5, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6900/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 5, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6900/

@richardlau richardlau mentioned this pull request Dec 5, 2025
Closed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 5, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6900/

@kxxt
Copy link
Contributor Author

kxxt commented Dec 6, 2025

node-test-commit-aix failure seems unrelated.
node-test-commit-arm failure is caused by transit network error.

Probably we should retry the CI.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 6, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70395/

@kxxt
Copy link
Contributor Author

kxxt commented Dec 6, 2025

Unfortunately, the aix CI failed again.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 6, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70401/

@kxxt
Copy link
Contributor Author

kxxt commented Dec 6, 2025

Could we skip or fix those flaky tests for aix CI instead of infinitely retrying it?
For reference, the set of tests that are flaky appears to be

addons.stringbytes-external-exceed-max.test-stringbytes-external-at-max
addons.stringbytes-external-exceed-max.test-stringbytes-external-exceed-max
addons.stringbytes-external-exceed-max.test-stringbytes-external-exceed-max-by-1-ascii
addons.stringbytes-external-exceed-max.test-stringbytes-external-exceed-max-by-1-base64
addons.stringbytes-external-exceed-max.test-stringbytes-external-exceed-max-by-1-binary 
addons.stringbytes-external-exceed-max.test-stringbytes-external-exceed-max-by-1-utf8

(Collected from a few recent failed runs)

luyahan and others added 2 commits December 6, 2025 22:11
@luyahan @kxxt
deps: V8: backport bbaae8e36164
5f16b76 
Original commit message:

    Reland "[riscv] Fix Check failed in bind_to"

    This is a reland of commit fdb5de2c741658e94944f2ec1218530e98601c23

    Original change's description:
    > [riscv] Fix Check failed in bind_to
    >
    > The trampoline should be emitted before the constant pool.
    >
    > Bug: 420232092
    >
    > Change-Id: I3a909b122607e37aca9d8765f28810ec74d5dc0b
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6578135
    > Auto-Submit: Yahan Lu (LuYahan) <yahan@iscas.ac.cn>
    > Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
    > Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn>
    > Cr-Commit-Position: refs/heads/main@{#100480}

    Bug: 420232092
    Change-Id: I1fac1ed8c349383ef4510abea338b3d695ed57ab
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6595668
    Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn>
    Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
    Cr-Commit-Position: refs/heads/main@{#100745}

Refs: v8/v8@bbaae8e
Co-authored-by: kxxt <rsworktech@outlook.com>
@luyahan @kxxt
deps: V8: cherry-pick 394a8053b59e
98cbf7d 
Original commit message:

    [riscv] Check trampoline before Constant pool in Release mode

    Change-Id: I9645cded9328dabb2c11c7859b998c838b95f97b
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6653368
    Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn>
    Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
    Cr-Commit-Position: refs/heads/main@{#100935}

Refs: v8/v8@394a805
@kxxt kxxt force-pushed the v24-bind-to-riscv branch from 60c872c to 98cbf7d Compare December 6, 2025 14:13
@kxxt
Copy link
Contributor Author

kxxt commented Dec 6, 2025

Rebased to fix conflict in v8_embedder_string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes

@sxa sxa sxa approved these changes

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RISCV] Check failed: (trampoline_pos - fixup_pos) <= kMaxBranchOffset.

5 participants

@kxxt @nodejs-github-bot @richardlau @sxa @luyahan