Skip to content

test: enforce better never-settling-promise detection #60976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
aduh95 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: enforce better never-settling-promise detection #60976

aduh95 wants to merge 1 commit into from
+451 −354

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Dec 6, 2025

Tests should be explicit regarding whether a promise is expected to settle, and the test should fail when the behavior does not meet expectations.

@aduh95
test: enforce better never-settling-promise detection
f510bd2 
Tests should be explicit regarding whether a promise is expected to
settle, and the test should fail when the behavior does not meet
expectations.
@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. async_hooks Issues and PRs related to the async hooks subsystem. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Dec 6, 2025
@codecov
Copy link

codecov bot commented Dec 6, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.53%. Comparing base (37d9cfc) to head (f510bd2).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #60976      +/-   ##
==========================================
+ Coverage   88.51%   88.53%   +0.02%     
==========================================
  Files         703      703              
  Lines      208430   208430              
  Branches    40198    40202       +4     
==========================================
+ Hits       184491   184540      +49     
+ Misses      15951    15897      -54     
- Partials     7988     7993       +5

see 50 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 6, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 6, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 6, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70404/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

addons Issues and PRs related to native addons. async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.

Projects

Node-API Team Project
Status: Need Triage

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aduh95 @nodejs-github-bot @cjihrig