chore(copilot): use GH_HOST for Copilot endpoints and token lookup #2090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Copilot HTTP requests and token lookup to respect the `GH_HOST` env var, allowing use with GitHub Enterprise instances. Some networks block the `github.com` endpoints, so they won't work at all. Provide a way for the user to hit different endpoint other than `github.com` (e.g. mycorp.ghe.com) without patching the source code. The `GH_HOST` environment variable is the same one used to override this for `gh` cli: https://cli.github.com/manual/gh_help_environment
Author
|
Maybe a cleaner solution would be to parse out of the oauth rather than looking for {"mycorp.ghe.com:Xy1.00deadbeef0":{"user":"my-user","oauth_token":"<nope>","githubAppId":"Xy1.00deadbeef0"}} |
Contributor
|
This PR is stale because it has been open for 30 days with no activity. |
|
@olimorris Any chance this could be merged? My company just updated copilot support to use Enterprise, so I can't use CodeCompanion anymore without this PR |
|
Well, I don't think this patch is enough... testing it locally I can see that the way the plugin handles URLs is too coupled, as the URL is always fully formed with host + path. The "real" fix would be to separate this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Copilot HTTP requests and token lookup to respect the
GH_HOSTenv var, allowing use with GitHub Enterprise instances.Some networks block the
github.comendpoints, so they won't work at all. Provide a way for the user to hit different endpoint other thangithub.com(e.g. mycorp.ghe.com) without patching the source code.The
GH_HOSTenvironment variable is the same one used to override this forghcli: https://cli.github.com/manual/gh_help_environmentNote: maybe this isn't the best solution, I'm not a lua guy... but I tested it in such a restrictive environment and it works.