Add New York City Map #2542
Add New York City Map #2542
Conversation
|
|
WalkthroughAdds a new map "New York City" and registers it across map assets, manifests, translations, map-generator, enums, client descriptions, default configuration, server playlist, and credits. No game logic or exported API signatures were changed. Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer (PR)
participant MapGen as map-generator
participant Repo as Repository (assets & manifests)
participant Server as Server (MapPlaylist, DefaultConfig)
participant Core as Core (GameMapType)
participant Client as Client (MapDescription, i18n)
Dev->>MapGen: add `newyorkcity` entry
Dev->>Repo: add `info.json` and `manifest.json`
Dev->>Server: add playlist frequency, add config entry
Dev->>Core: add GameMapType.NewYorkCity, add to categories
Dev->>Client: add MapDescription and i18n key
Note right of Repo: Assets + manifest now available to build pipeline
Server->>Core: reads enum & config at runtime (registration)
Client->>Core: uses enum -> render map list (localized)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Suggested labels
Suggested Reviewers
Poem
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (9)
🚧 Files skipped from review as they are similar to previous changes (7)
🧰 Additional context used🧠 Learnings (1)📚 Learning: 2025-08-19T11:00:55.422ZApplied to files:
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
can you add https://en-gb.topographic-map.com/ and the map you used in the CREDITS.md their license requires attribution: https://opendatacommons.org/licenses/odbl/summary/ |
There was a problem hiding this comment.
please keep same format as the other info.json
There was a problem hiding this comment.
Fixed - This was an artifact from the online map editor that I forgot to remove after shuffling the nations a bit. Whoops!
Tidwell
force-pushed
the
new-york-city-map
branch
from
18996fa to
1e276bb
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CREDITS.md (1)
31-39: Clarify specific NYC topo / antique map sources in creditsThe new entries look good, but they are still quite generic:
- For Topographic Map, the earlier review asked for “topographic map URL and specific map used”. Right now this points to the site root only. Please consider adding the exact NYC map page or dataset name you used so the attribution is clearly tied to the data actually in the game.
- For Geographicus Rare Antique Maps, please double‑check that the specific NYC map you used is indeed public domain, and if so, link that map’s page (title, year) instead of only the site root. That makes future license audits much easier.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (4)
map-generator/assets/maps/newyorkcity/image.pngis excluded by!**/*.pngresources/maps/newyorkcity/map.binis excluded by!**/*.binresources/maps/newyorkcity/map16x.binis excluded by!**/*.binresources/maps/newyorkcity/map4x.binis excluded by!**/*.bin
📒 Files selected for processing (9)
CREDITS.md(1 hunks)map-generator/assets/maps/newyorkcity/info.json(1 hunks)map-generator/main.go(1 hunks)resources/lang/en.json(1 hunks)resources/maps/newyorkcity/manifest.json(1 hunks)src/client/components/Maps.ts(1 hunks)src/core/configuration/DefaultConfig.ts(1 hunks)src/core/game/Game.ts(2 hunks)src/server/MapPlaylist.ts(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (7)
- resources/lang/en.json
- map-generator/main.go
- src/core/configuration/DefaultConfig.ts
- src/core/game/Game.ts
- src/server/MapPlaylist.ts
- resources/maps/newyorkcity/manifest.json
- map-generator/assets/maps/newyorkcity/info.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: 🔬 Test
🔇 Additional comments (1)
src/client/components/Maps.ts (1)
38-38: NYC map description entry is consistent and type‑safe
NewYorkCity: "New York City"matches the enum naming and existing description pattern (e.g., Montreal), and keepsMapDescriptionaligned withGameMapType. No changes needed here.
Added two entries to the
|
Tidwell
force-pushed
the
new-york-city-map
branch
from
816a6b6 to
85b7715
Compare
… Update new-york-city map json to remove metadata properties from map editor
Tidwell
force-pushed
the
new-york-city-map
branch
from
85b7715 to
62e9a12
Compare
3 participants
Description:
Adds New York City Map.
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
tidwell
Screenshots
Misc
Dimensions: 1500 x 1900 px
Total Area: 2,850,000 px²
New Flag Assets: None
Inspired by this Discord Thread
Some of the water features are adjusted for playability. NYC doesn't have a ton of elevation differences, so marshland is replicated w/ highland noise. This is roughly placed to match Pre-WWI, but allows maintaining the modern silhouette of the area. This 1901 map is also the main inspiration for composition and projection. For the Nations, British and Dutch Colonies along with Native Peoples make this a bit of an amalgamation of the 17th - 20th centuries
Other elevation differences come from Topographic Map
Tribal Nation Names and Info
Additional Tribal Names/Info