-
-
Notifications
You must be signed in to change notification settings - Fork 153
Open
Labels
Compatpandas objects compatability with Numpy or Python functionspandas objects compatability with Numpy or Python functionsTestingpandas testing functions or related to the test suitepandas testing functions or related to the test suite
Description
With the changes we've made to how we refer to numpy types, we need to change lines like this in test_plotting.py:
check(assert_type(df.hist(), npt.NDArray[np.object_]), npt.NDArray[np.object_])to
check(assert_type(df.hist(), npt.NDArray[np.object_]), np.ndarray)See numpy/numpy#30319 (comment) and comments below for discussion. We shouldn't be passing the typing type npt.NDArray as the klass to check()
Metadata
Metadata
Assignees
Labels
Compatpandas objects compatability with Numpy or Python functionspandas objects compatability with Numpy or Python functionsTestingpandas testing functions or related to the test suitepandas testing functions or related to the test suite