fix: sub-folders not showing up in browse-by-folder view due to wrong empty check in query #14821
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing in browse-by-folder view
GeorgS
requested review from
AlessioGr,
JarrodMFlesch and
jacobsfletch
as code owners
GeorgS
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Sub folders don't show up when creating them or browsing through the browse-by-folder/select folder view.
Why?
As there is currently no way to navigate through sub folders in either the global browse-by-folder without having to set the "folder" filter first or when selecting a sub-folder from a collection.
How?
As the result returns an empty array if there are no collections assigned, I've changed the query to check for
equals: []instead ofexists: false. This might be related to #12072.Before
bug_folder_view.mov
After
fix_folder_view.mov