Rule proposal: `no-useless-iterator-to-array`

[fisker]

Description

Very similar to no-useless-spread, but I don't think it make sense to add to no-useless-spread

Examples

// ❌
const set = new Set(iterator.toArray());

// ✅
const set = new Set(iterator);

// ❌
for (const foo of iterator.toArray());

// ✅
for (const foo of iterator);

More examples see no-useless-spread, replace ... to .toArray()

Proposed rule name

no-useless-iterator-to-array

Additional Info

No response

[fisker]

Should also report array methods that also exists in Iterator

// ❌
iterator.toArray().every()

// ✅
iterator.every()

// ❌
iterator.toArray().find()

// ✅
iterator.find()

Full list https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Iterator

map and flatMap should not include