-
Notifications
You must be signed in to change notification settings - Fork 17
feat: report connector version info #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.0
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @qevolg, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a new feature to automatically report the version of the Python WebSocket connector to the server. This allows for better tracking and identification of client applications connecting to the service. The changes involve embedding the connector's version string into connection DSNs and consumer builders, alongside necessary updates to Rust dependencies and the introduction of dedicated tests to ensure the functionality works as expected. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
a5566de to
016c018
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully adds the functionality to report connector version information. The changes in the Rust code are correct and effectively implement the feature. My review focuses on the new Python tests, where I've suggested improvements to enhance their reliability and readability. Specifically, I've pointed out the use of fixed time.sleep() calls, which can lead to flaky tests, and recommended replacing them with a more robust polling mechanism. I've also provided suggestions to make the test code more concise and Pythonic. Additionally, I've noted a skipped test and asked for clarification on its status.
1fb370c to
34d9ce8
Compare
34d9ce8 to
ffa4197
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.0 #376 +/- ##
=======================================
Coverage 81.42% 81.42%
=======================================
Files 24 24
Lines 3569 3569
=======================================
Hits 2906 2906
Misses 663 663 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Report connector version info
Jira: https://jira.taosdata.com:18080/browse/TD-36923
Checklist
Please check the items in the checklist if applicable.