Skip to content

Conversation

@qevolg
Copy link
Contributor

@qevolg qevolg commented Dec 2, 2025

Description

Report connector version info

Jira: https://jira.taosdata.com:18080/browse/TD-36923

Checklist

Please check the items in the checklist if applicable.

  • Is the user manual updated?
  • Are the test cases passed and automated?
  • Is there no significant decrease in test coverage?

@gemini-code-assist
Copy link

Summary of Changes

Hello @qevolg, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a new feature to automatically report the version of the Python WebSocket connector to the server. This allows for better tracking and identification of client applications connecting to the service. The changes involve embedding the connector's version string into connection DSNs and consumer builders, alongside necessary updates to Rust dependencies and the introduction of dedicated tests to ensure the functionality works as expected.

Highlights

  • Connector Version Reporting: The Python WebSocket connector now reports its version information (e.g., 'PythonWS-X.Y.Z') to the server, enhancing client identification.
  • Dependency Updates: Several Rust dependencies were updated, including the addition of chrono-tz, phf, signal-hook-registry, siphasher, and tokio-util, while deadpool and deadpool-runtime were removed. The taos-connector-rust dependency was also updated to a specific feature branch.
  • New Test Cases: New tests have been added to verify that the connector version information is correctly reported for both standard connections and consumer instances.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@qevolg qevolg force-pushed the feat/3.0/TD-36923 branch from a5566de to 016c018 Compare December 2, 2025 08:07
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully adds the functionality to report connector version information. The changes in the Rust code are correct and effectively implement the feature. My review focuses on the new Python tests, where I've suggested improvements to enhance their reliability and readability. Specifically, I've pointed out the use of fixed time.sleep() calls, which can lead to flaky tests, and recommended replacing them with a more robust polling mechanism. I've also provided suggestions to make the test code more concise and Pythonic. Additionally, I've noted a skipped test and asked for clarification on its status.

@qevolg qevolg force-pushed the feat/3.0/TD-36923 branch 2 times, most recently from 1fb370c to 34d9ce8 Compare December 2, 2025 08:22
@qevolg qevolg force-pushed the feat/3.0/TD-36923 branch from 34d9ce8 to ffa4197 Compare December 2, 2025 08:29
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.42%. Comparing base (93d8af2) to head (ffa4197).

Additional details and impacted files
@@           Coverage Diff           @@
##              3.0     #376   +/-   ##
=======================================
  Coverage   81.42%   81.42%           
=======================================
  Files          24       24           
  Lines        3569     3569           
=======================================
  Hits         2906     2906           
  Misses        663      663           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants