Skip to content

Conversation

@danfimov
Copy link
Member

@danfimov danfimov commented Dec 6, 2025

  • Add 3.14 to test suilt
  • Declare support in tags
  • Fix warning in tests with 3.14 about asyncio.iscoroutinefunction deprecation in 3.16

Copilot AI review requested due to automatic review settings December 6, 2025 19:51
@danfimov danfimov changed the title feat: add 3 14 support feat: add python 3.14 support Dec 6, 2025
@danfimov danfimov requested a review from s3rius December 6, 2025 19:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for Python 3.14 by updating the test matrix, classifiers, and fixing compatibility issues. The changes include adapting the coroutine function detection logic for Python 3.14's improved inspect.iscoroutinefunction, fixing test declarations that were incorrectly marked as async, and adding an ensure_ascii parameter to the JSON serializer.

Key changes:

  • Added Python 3.14 to the CI test matrix and package classifiers
  • Updated coroutine function detection to use inspect.iscoroutinefunction for Python 3.14+
  • Fixed JSON serializer tests to be synchronous (removed unnecessary async declarations)
  • Added ensure_ascii parameter to JSONSerializer class with corresponding tests

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/serializers/test_json_serializer.py Corrected test functions from async to sync, removed PLR2004 noqa comments (now globally ignored), and added parametrized test for ensure_ascii parameter
taskiq/serializers/json_serializer.py Added ensure_ascii parameter to JSONSerializer constructor and applied it in dumpb method
taskiq/receiver/receiver.py Added Python version detection and conditional use of inspect.iscoroutinefunction for Python 3.14+ to address coroutine detection improvements
pyproject.toml Added Python 3.14 classifier and globally ignored PLR2004 (magic value) rule for all test files
.github/workflows/test.yml Added Python 3.14 to the test matrix

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@danfimov danfimov self-assigned this Dec 7, 2025
@danfimov danfimov added the enhancement New feature or request label Dec 7, 2025
@danfimov danfimov changed the title feat: add python 3.14 support feat: declare python 3.14 support Dec 7, 2025
@s3rius s3rius merged commit 5825b9a into master Dec 7, 2025
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants