test all docker clients

modify TestFixture to support dind and different clients
add dind for tls client tests to ci
add parallel test
add speed test
check for com.docker.service in Docker_IsRunning too
add 1s sleep in MonitorEventsFiltered_Succeeds test

Author: bruegth

.github/workflows/ci.yml

@@ -8,6 +8,29 @@ on:
 jobs:
   build:
     runs-on: ubuntu-22.04
+    services:
+      # Docker without TLS (plain TCP) !DEPRECATED! with next docker release
+      docker-no-tls:
+        image: docker:28.1-dind
+        env:
+          DOCKER_TLS_CERTDIR: ""
+        ports:
+          - 2375:2375
+        options: >-
+          --privileged
+
+      # Docker with TLS (secure TCP)
+      docker-tls:
+        image: docker:28.1-dind
+        env:
+          DOCKER_TLS_CERTDIR: /certs
+        ports:
+          - 2376:2376
+        options: >-
+          --privileged
+        volumes:
+          - ${{ github.workspace }}/certs:/certs
+
     strategy:
       matrix:
         framework:
@@ -16,12 +39,53 @@ jobs:
     steps:
       - uses: actions/checkout@v4
         with:
+          path: test
           fetch-depth: 0
       - name: Setup .NET Core
         uses: actions/setup-dotnet@v4
         with:
           dotnet-version: 9.x
       - name: Build
         run: dotnet build -c Release --framework ${{ matrix.framework }}
+        working-directory: test
+
+      - name: Pack client cert, key, ca for C# docker client
+        run: |
+          mkdir -p ${{ github.workspace }}/certs
+          sudo chmod 777 ${{ github.workspace }}/certs
+
+          # create pfx
+          openssl pkcs12 -export -out ${{ github.workspace }}/certs/client.pfx -inkey ${{ github.workspace }}/certs/client/key.pem -in ${{ github.workspace }}/certs/client/cert.pem -certfile ${{ github.workspace }}/certs/client/ca.pem -passout pass:
+
+      - name: Wait for Docker (no TLS) to be healthy
+        run: |
+          for i in {1..10}; do
+            if docker --host=tcp://localhost:2375 version; then
+              echo "Docker (no TLS) is ready!"
+              exit 0
+            fi
+            echo "Waiting for Docker (no TLS) to be ready..."
+            sleep 3
+          done
+          echo "Docker (no TLS) did not become ready in time."
+          exit 1
+
+      - name: Wait for Docker (with TLS) to be healthy
+        run: |
+          for i in {1..10}; do
+            if docker --host=tcp://localhost:2376 --tlsverify \
+              --tlscacert=${{ github.workspace }}/certs/client/ca.pem \
+              --tlscert=${{ github.workspace }}/certs/client/cert.pem \
+              --tlskey=${{ github.workspace }}/certs/client/key.pem version; then
+              echo "Docker (TLS) is ready!"
+              exit 0
+            fi
+            echo "Waiting for Docker (TLS) to be ready..."
+            sleep 3
+          done
+          echo "Docker (TLS) did not become ready in time."
+          exit 1
+
       - name: Test
         run: dotnet test -c Release --framework ${{ matrix.framework }} --no-build --logger console
+        working-directory: test

test/Docker.DotNet.Tests/CommonCommands.cs

@@ -4,5 +4,7 @@ public static class CommonCommands
 {
     public static readonly string[] SleepInfinity = ["/bin/sh", "-c", "trap \"exit 0\" TERM INT; sleep infinity"];
 
-    public static readonly string[] EchoToStdoutAndStderr = ["/bin/sh", "-c", "trap \"exit 0\" TERM INT; while true; do echo \"stdout message\"; echo \"stderr message\" >&2; sleep 1; done"];
+    public static readonly string[] EchoToStdoutAndStderr = ["/bin/sh", "-c", "trap \"exit 0\" TERM INT; RND=$RANDOM; while true; do echo \"stdout message $RND\"; echo \"stderr message $RND\" >&2; sleep 1; done"];
+
+    public static readonly string[] EchoToStdoutAndStderrFast = ["/bin/sh", "-c", "trap \"exit 0\" TERM INT; RND=$RANDOM; while true; do echo \"stdout message $RND\"; echo \"stderr message $RND\" >&2; done"];
 }

test/Docker.DotNet.Tests/Docker.DotNet.Tests.csproj

@@ -12,7 +12,12 @@
   <ItemGroup>
     <ProjectReference Include="..\..\src\Docker.DotNet.BasicAuth\Docker.DotNet.BasicAuth.csproj" />
     <ProjectReference Include="..\..\src\Docker.DotNet.X509\Docker.DotNet.X509.csproj" />
+    <ProjectReference Include="..\..\src\Docker.DotNet.NPipe\Docker.DotNet.NPipe.csproj" />
+    <ProjectReference Include="..\..\src\Docker.DotNet.Unix\Docker.DotNet.Unix.csproj" />
+    <ProjectReference Include="..\..\src\Docker.DotNet.NativeHttp\Docker.DotNet.NativeHttp.csproj" />
+    <ProjectReference Include="..\..\src\Docker.DotNet.LegacyHttp\Docker.DotNet.LegacyHttp.csproj" />
     <ProjectReference Include="..\..\src\Docker.DotNet\Docker.DotNet.csproj" />
+    
   </ItemGroup>
   <ItemGroup>
     <Content Include="xunit.runner.json" CopyToOutputDirectory="PreserveNewest" />

test/Docker.DotNet.Tests/IConfigOperationsTests.cs

@@ -12,10 +12,14 @@ public IConfigOperationsTests(TestFixture testFixture, ITestOutputHelper testOut
         _testOutputHelper = testOutputHelper;
     }
 
-    [Fact]
-    public async Task SwarmConfig_CanCreateAndRead()
+    public static IEnumerable<object[]> GetDockerClientTypes() =>
+        TestFixture.GetDockerClientTypes();
+
+    [Theory]
+    [MemberData(nameof(GetDockerClientTypes))]
+    public async Task SwarmConfig_CanCreateAndRead(TestClientsEnum clientType)
     {
-        var currentConfigs = await _testFixture.DockerClient.Configs.ListConfigsAsync();
+        var currentConfigs = await _testFixture.DockerClients[clientType].Configs.ListConfigsAsync();
 
         _testOutputHelper.WriteLine($"Current Configs: {currentConfigs.Count}");
 
@@ -31,15 +35,15 @@ public async Task SwarmConfig_CanCreateAndRead()
             Config = testConfigSpec
         };
 
-        var createdConfig = await _testFixture.DockerClient.Configs.CreateConfigAsync(configParameters);
+        var createdConfig = await _testFixture.DockerClients[clientType].Configs.CreateConfigAsync(configParameters);
         Assert.NotNull(createdConfig.ID);
         _testOutputHelper.WriteLine($"Config created: {createdConfig.ID}");
 
-        var configs = await _testFixture.DockerClient.Configs.ListConfigsAsync();
+        var configs = await _testFixture.DockerClients[clientType].Configs.ListConfigsAsync();
         Assert.Contains(configs, c => c.ID == createdConfig.ID);
         _testOutputHelper.WriteLine($"Current Configs: {configs.Count}");
 
-        var configResponse = await _testFixture.DockerClient.Configs.InspectConfigAsync(createdConfig.ID);
+        var configResponse = await _testFixture.DockerClients[clientType].Configs.InspectConfigAsync(createdConfig.ID);
 
         Assert.NotNull(configResponse);
 
@@ -51,8 +55,8 @@ public async Task SwarmConfig_CanCreateAndRead()
 
         _testOutputHelper.WriteLine("Config created is the same.");
 
-        await _testFixture.DockerClient.Configs.RemoveConfigAsync(createdConfig.ID);
+        await _testFixture.DockerClients[clientType].Configs.RemoveConfigAsync(createdConfig.ID);
 
-        await Assert.ThrowsAsync<DockerApiException>(() => _testFixture.DockerClient.Configs.InspectConfigAsync(createdConfig.ID));
+        await Assert.ThrowsAsync<DockerApiException>(() => _testFixture.DockerClients[clientType].Configs.InspectConfigAsync(createdConfig.ID));
     }
 }