Skip to content

Reserve ecam v express #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
vbpandya wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Reserve ecam v express #730

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afc96ea
Platform/Arm/VExpressPkg: Reserve the ECAM area in ACPI with RES0 device
vbpandya Dec 30, 2024
4005ab3
Platform/Arm/Juno: Use common PCDs for ARM platform
vbpandya Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Platform/ARM/VExpressPkg/ArmVExpressPkg.dec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@
gArmVExpressTokenSpaceGuid.PcdHdLcdVideoModeOscId|0|UINT32|0x00000005
gArmVExpressTokenSpaceGuid.PcdArmMaliDpMaxMode|0|UINT32|0x00000008

gArmTokenSpaceGuid.PcdPciConfigurationSpaceSize|0x10000000|UINT64|0x00000011
Copy link
Contributor

@samimujawar samimujawar Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is the gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseSize different from gArmTokenSpaceGuid.PcdPciConfigurationSpaceSize, can you check, please?

See https://github.com/tianocore/edk2/blob/master/MdePkg/MdePkg.dec#L2538

gArmTokenSpaceGuid.PcdPciConfigurationSpaceLimit|0x4FFFFFFF|UINT64|0x00000012

#
# Device path of block device on which Fastboot will flash partitions
#
Expand Down
13 changes: 13 additions & 0 deletions Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/SsdtPci.asl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,19 @@ DefinitionBlock ("SsdtPci.aml", "SSDT", 2, "ARMLTD", "FVP-REVC", 1) {
Return (RBUF)
} // Method(_CRS)

Device (RES0) {
Name (_HID, "PNP0C02" /* PNP Motherboard Resources */) // _HID: Hardware ID
Name (_CRS, ResourceTemplate () { // _CRS: Current Resource Settings
QWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, NonCacheable, ReadWrite,
0x0000000000000000, // Granularity
FixedPcdGet64 (PcdPciExpressBaseAddress), // Range Minimum
FixedPcdGet64 (PcdPciConfigurationSpaceLimit), // Range Maximum
Copy link
Contributor

@samimujawar samimujawar Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if the Size be used from https://github.com/tianocore/edk2-platforms/blob/master/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc#L212-L213, please?
If so believe the Limit can be computed, right?

0x0000000000000000, // Translation Offset
FixedPcdGet64 (PcdPciConfigurationSpaceSize), // Length
,, , AddressRangeMemory, TypeStatic)
})
}

//
// OS Control Handoff
//
Expand Down
2 changes: 2 additions & 0 deletions .../ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@
# PCI Root complex specific PCDs
gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress
gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseSize
gArmTokenSpaceGuid.PcdPciConfigurationSpaceSize
gArmTokenSpaceGuid.PcdPciConfigurationSpaceLimit

gArmTokenSpaceGuid.PcdPciBusMin
gArmTokenSpaceGuid.PcdPciBusMax
Expand Down