Add exception.type to error events #243
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure we always append `exception.type` to the span events any time we convert an error to an exception. This is required to make Datadog platform happy and avoid the "Missing error message and stack trace" error.
Current default branch is broken, failing the build. I am doing a change that I think is appropriate here, but open to feedback.
Comment on lines
+147
to
+150
| status, | ||
| } => { | ||
| builder.attributes.get_or_insert(Vec::new()).push(key_value); | ||
| builder.status = status.clone(); |
Author
There was a problem hiding this comment.
Please double-check this for me. At the moment, the default branch if failing to build, because the status field isn't properly matched. I think I am doing the right thing here, but if I should rather ignore the status instead of setting it on the builder, please let me know and I will make an update.
Use `Unknown` as an `exception.type` instead of `dyn ...` types as per our conversation in the original issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we add
exception.typefield to span events any time we report an error as an exception.Motivation
This change is addressing the issue described in #242, where traces that are sent to Datadog that contained errors would not properly link and render, causing an error in Datadog's UI:
Missing error message and stack trace.Solution
Datadog apparently requires at least the
exception.messageandexception.typefields to be present.Closes #242
Closes tokio-rs/tracing#2648