fix(data-table): allow rowSpan and colSpan on selection column type #7349
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix TypeScript type definition for [TableSelectionColumn] to allow
rowSpanandcolSpanproperties.Closes #7347
Problem
When using
rowSpanorcolSpanon a selection column, TypeScript reports an error:Type '(rowData: T) => number' is not assignable to type 'undefined'.
However, the runtime behavior works correctly - selection cells can be merged as expected.
Root Cause
In commit
f56d978(2021-03-24), whenrowSpanandcolSpanwere added to [TableBaseColumn], they were explicitly set toneveron [TableSelectionColumn] This was likely an intentional design decision at the time, but it doesn't match the actual runtime behavior where these properties are supported.Solution
Change the type definition from:
to:
This aligns the type definition with the actual runtime behavior.