-
-
Notifications
You must be signed in to change notification settings - Fork 11.8k
[ROCm][CI] Fix test_max_len.py for Rocm #29916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: charlifu <charlifu@amd.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the attention backend for ROCm in the test utilities, changing it from FLASH_ATTN to ROCM_AITER_FA. This aligns with using the Aiter Flash Attention backend on ROCm platforms. My review includes a suggestion to update a related log message for consistency and to prevent confusion during debugging.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Charlie Fu <Charlie.Fu@amd.com>
Signed-off-by: charlifu <charlifu@amd.com>
|
Hi @charlifu , can you also update it here: vllm/tests/v1/e2e/test_spec_decode.py Lines 400 to 418 in 1c593e1
|
|
This pull request has merge conflicts that must be resolved before it can be |
87c1f4d to
d38904b
Compare
Signed-off-by: charlifu <charlifu@amd.com>
Signed-off-by: charlifu <charlifu@amd.com>
|
@charlifu after you done fixing it, can you share the tests status of the files that you have fixed? |
|
on mi300x, I am getting OOM issues on two of the tests. May I know which machine are you validating on? mi325? |
robertgshaw2-redhat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing approval since @tjtanaa is on point
Signed-off-by: charlifu <charlifu@amd.com>
9 passed, 4 warnings in 202.83s (0:03:22)
51 passed, 4 warnings in 37.66s |
|
@charlifu how about the status of |
Still failing, but that's not what this PR aiming for. Can we get this merged first? |
Signed-off-by: charlifu <charlifu@amd.com>
|
Another fix here:
=============== 34 passed, 6 warnings in 480.39s (0:08:00) ========== |
tjtanaa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's not any more tests. Open another PR if there are new tests.
|
@micah-wil I saw you have merged the bugfix PR into this PR by syncing from main. Are the test cases in |
Use ROCM_AITER_FA backend for flash attn on rocm.