Add meta doc urls #337
Open
Add meta doc urls #337
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cht8687
force-pushed
the
master
branch
2 times, most recently
from
5559a1c to
bd9b25e
Compare
binury
approved these changes
Apr 13, 2024
binury
left a comment
binury
left a comment
There was a problem hiding this comment.
once conflicting commit is dropped, LGTM 👍 👍
tests/lib/rules/all.js
Outdated
| ], | ||
| invalid: [{ | ||
| code: '_.first([0, 1, 3])', | ||
| errors: ['Consider using the native Array.prototype.slice()'] |
There was a problem hiding this comment.
This rule.alternative change shouldn't since it is outside the scope of the primary change. Also, to a lesser extent it no longer (two years later 😅) exists within this file either- and so this commit is the cause of the merge conflict
There was a problem hiding this comment.
(but -good news- the equivalent change you made was later added here)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add urls to the documentation to provide every rule with a link to the full documentation.