agent_ui: Disable send when tool is awaiting confirmation #44260
+83
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
SomeoneToIgnore
added
the
area:ai
florian-trehaut
force-pushed
the
fix/duplicate-tool-use-ids-44211
branch
from
adef40e to
2fac8c9
Compare
florian-trehaut
changed the title
florian-trehaut
changed the title
florian-trehaut
force-pushed
the
fix/duplicate-tool-use-ids-44211
branch
from
2fac8c9 to
76de27c
Compare
…ries#44211) Workaround for API error 400 (duplicate tool_use IDs) when sending a message while a tool awaits confirmation. The root cause is not yet identified and requires further investigation. This fix prevents the problematic scenario at the UI level by blocking message sending when a tool awaits confirmation. Changes: - Add has_tool_awaiting_confirmation() helper method - Block send() when a tool awaits confirmation - Disable send button visually with informative tooltip Users must click Accept/Reject on tool confirmations before sending new messages. Fixes zed-industries#44211
florian-trehaut
force-pushed
the
fix/duplicate-tool-use-ids-44211
branch
from
76de27c to
15c2044
Compare
maxdeviant
changed the title
maxdeviant
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #44211
Summary
Workaround for API error 400 (
tool_use ids must be unique) when sending a message while a tool awaits confirmation (e.g., ExitPlanMode in plan mode).The root cause is not yet identified and requires further investigation. This fix prevents the problematic scenario at the UI level.
Changes
thread_view.rs:has_tool_awaiting_confirmation()helper methodsend()when a tool awaits confirmationBehavior
Users must click Accept/Reject on tool confirmations before sending new messages. This prevents users from losing their Claude session and conversation context.
Testing
Added test
test_message_doesnt_send_if_tool_awaiting_confirmation.Release Notes: