Skip to content

Conversation

@koji
Copy link
Contributor

@koji koji commented Dec 4, 2025

Overview

add Skeleton component for second window

SkeletonForSlotDetail.mov

close AUTH-2558

Test Plan and Hands on Testing

  • select a protocol
  • click visualization button
  • click a slot

Changelog

  • add SkeletonForSlotDetail component and its test

Review requests

Risk assessment

low

@koji koji requested review from jerader and ncdiehl11 December 4, 2025 23:00
@koji koji marked this pull request as ready for review December 4, 2025 23:00
@koji koji added the authorship label Dec 4, 2025
@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

❌ Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 57.04%. Comparing base (a6d7686) to head (10ed09f).

Files with missing lines Patch % Lines
app/src/pages/Desktop/StepDetailViewer/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             edge   #20298       +/-   ##
===========================================
+ Coverage   25.78%   57.04%   +31.25%     
===========================================
  Files        3623     3624        +1     
  Lines      301823   301950      +127     
  Branches    42342    42588      +246     
===========================================
+ Hits        77827   172247    +94420     
+ Misses     223967   129476    -94491     
- Partials       29      227      +198     
Flag Coverage Δ
app 46.26% <95.23%> (+45.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...Desktop/StepDetailViewer/SkeletonForSlotDetail.tsx 100.00% <100.00%> (ø)
app/src/pages/Desktop/StepDetailViewer/index.tsx 3.44% <0.00%> (+3.44%) ⬆️

... and 1842 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants