Fix #4568: Correct MPL-2.0 badge rule to prevent false positives on I… #4620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ositives on ISC badges Signed-off-by: saransh-2504 <saransh2504@gmail.com>
saransh-2504
force-pushed
the
issue-4568
branch
from
e95a5bf to
dc033d7
Compare
Author
|
Hi! This PR fixes the badge false detection issue #4568. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4568
What was wrong
ScanCode identified MPL-2.0 in README.md of dnspython v2.6.1 due to an overly broad
MPL badge rule (
mpl-2.0_url_badge.RULE). The rule matched non-MPL badges such asthe ISC license badge, causing a false-positive detection.
What I did
Testing
pytest -k "mpl") pass