Add I2C support to the Zephyr builds #10735
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You cannot instantiate `zephyr_i2c.I2C()` because they are fixed by the board's device tree. All busses with status = "okay" are added to board with all of their labels as names. So, I2C() may be the same as I2C1() and ARDUINO_I2C(). Part of micropython#9903.
dhalbert
previously approved these changes
Dec 6, 2025
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Thanks! Looks good to me, but did not test.
It's too bad there's so much duplicated code and documentation. If the documentation is largely the same for busio.I2C, I wonder if it should cross-reference that instead of copying it. The shared-binding code of busio.I2C vs zephyr_i2c.I2C also seems to be pretty much identical, or are there subtle differences? I don't see how to get around that except maybe if one macro-ified the the shared-binding source so it could be instantiated several different ways. But it's quite messy to do that in C.
| //| | ||
| //| Cannot be instantiated directly. Instead singletons are created using the | ||
| //| ``board`` aliases that match the device tree labels. ``board`` may list multiple | ||
| //| aliases for a single device. For example, ``board.I2C1`` and ``board.ARDUINO_I2C`` |
Collaborator
There was a problem hiding this comment.
Should these have parens?
Suggested change
| //| aliases for a single device. For example, ``board.I2C1`` and ``board.ARDUINO_I2C`` | |
| //| aliases for a single device. For example, ``board.I2C1()`` and ``board.ARDUINO_I2C()`` |
dhalbert
requested changes
Dec 6, 2025
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
One possible change in doc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You cannot instantiate
zephyr_i2c.I2C()because they are fixed by the board's device tree. All busses with status = "okay" are added to board with all of their labels as names. So, I2C() may be the same as I2C1() and ARDUINO_I2C().Part of #9903.