Consolidate error handling behaviour for ApplyExtendImplAs (Refactor Impl construction 4/7)
#6468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagate error state in an
extend impldeclaration out to the enclosing scope. We can do this generically inApplyExtendImplAsso we don't have to do it explicitly in other places.Collapse
DiagnoseExtendImplOutsideClassintoApplyExtendImplAsas it had only the one caller and is very small, so this simplifies the code, makingApplyExtendImplAsa clear set of diagnostics. And push the construction of the SpecificConstant down intoApplyExtendImplAsso it is only constructed if it's needed, instead of constructing it and throwing it away in error cases.Ensure any error in the declaration results in the witness being an ErrorInst so the impl will not be used in impl lookup. This simplifies some branches by combining them into a single if statement.
This is part of #6420 which is being split up into a chain of smaller PRs. It is based on #6467.