Skip to content

fix: allow empty keys assertion when target object is empty #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
milanchahar wants to merge 7 commits into
base: main
Choose a base branch
from
+8 −1
Open

fix: allow empty keys assertion when target object is empty #1753

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2560e37
fix: allow empty keys assertion when target object is empty (revives …
milanchahar Nov 29, 2025
1bafe85
refactor: move empty keys tests to expect.js
milanchahar Nov 30, 2025
f186707
fix: strict logic for empty keys
milanchahar Dec 1, 2025
02c6815
style: revert formatter changes and update comments per review
milanchahar Dec 3, 2025
ef7eee3
fix(assertions): allow empty keys for all-keys assertions; move tests…
milanchahar Dec 4, 2025
b4f4d49
Fixed all formatter related issues and added test
milanchahar Dec 4, 2025
2560ea3
restore assertions.js
milanchahar Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions lib/chai/core/assertions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2524,10 +2524,6 @@ function assertKeys(keys) {
});
}

if (!keys.length) {
throw new AssertionError(flagMsg + 'keys required', undefined, ssfi);
}

let len = keys.length,
any = flag(this, 'any'),
all = flag(this, 'all'),
Expand All @@ -2538,6 +2534,12 @@ function assertKeys(keys) {
all = true;
}

// Fix for PR #1384: Allow empty keys only if we are checking 'all'.
// 'any' keys requires at least one key to be checked against.
Copy link
Contributor

@43081j 43081j Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Fix for PR #1384: Allow empty keys only if we are checking 'all'.
// 'any' keys requires at least one key to be checked against.
// Allow empty keys if we're checking `all` since you can assert it has _no keys_
// For `any`, we need at least one key.

since the PR isn't relevant info anymore at this point (its a feature rather than a bug)

if (!keys.length && !all) {
throw new AssertionError(flagMsg + 'keys required', undefined, ssfi);
}

// Has any
if (any) {
ok = expected.some(function (expectedKey) {
Expand Down
Loading